Add permit with standard signature validation to ERC20Bridged - #2
Draft
matjazv wants to merge 5 commits into
Draft
Add permit with standard signature validation to ERC20Bridged#2matjazv wants to merge 5 commits into
matjazv wants to merge 5 commits into
Conversation
Adding data about repo for the potential Op grant
matjazv
force-pushed
the
l2/lisk
branch
2 times, most recently
from
July 18, 2024 14:25
62b4f35 to
83e849e
Compare
matjazv
marked this pull request as draft
December 9, 2024 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lido recommendation R8 prefers that the bridged
wstETHshould support EIP-2612 permit ERC-20 token extension with EIP-1271 standard signature validation method for contracts.Therefore
ERC20Bridgedtoken inheritsERC20Permitsmart contract which has an appropriate implementation to support EIP-1271.There are also unit tests to confirm new functionality is working as intended.