test-data: acquire D1 corpus fixture - #8
Merged
Merged
Conversation
lipluscodex
commented
Aug 1, 2026
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
AI self-review
実装差分は PASS。merge gate は github-rag-mcp#178 の backfill / coverage 再比較待ち。
Acceptance criteria
- 本番 D1 取得を単一
SELECT / WITHに制限し、全 query のrows_written=0/changes=0/changed_db=falseを検証: PASS - live
search_docs/doc_edgesschema fingerprint と変換契約の固定: PASS - 決定論的な小 fixture、provenance、欠損 endpoint 集計、credential-like文字列の最終payload全体でのredaction: PASS
- 実fixtureによる ingest / search / time metadata / graph activation / success feedback: PASS
- coverage比較tool、取得・完全性限界・再取得手順の文書化: PASS
- #178 backfill後の再取得とcoverage比較: PENDING(2026-08-01時点で対象gap scanは0件、#178は
waiting)
Review findings resolved
- 空文字
commit_shaがnon-diff surfaceでdistinct commit 1件として数えられる問題をNULLIFと回帰テストで修正。 - source引数 / known gap からfixture・provenanceへcredential-like文字列が入る経路を最終payload redactionと回帰テストで修正。
Verification
- Local: 21/21 tests PASS、eval PASS
- Production recapture: committed fixtureとbyte-identical、zero-write、redactions 0
- GitHub CI: PASS
- PR merge state: CLEAN
Scope deviation: なし。
Next step: #178 backfill完了後に同一引数で再取得し、coverage差分を確認してfixture / provenanceを必要に応じて更新、CI greenを再確認してからmergeする。
本番 D1 の backfill 完了後に fixture と provenance を再取得した。 既知 gap の空配列契約を requirements、docs、test に反映した。
解消済みの #178 を取得例の known gap 指定から除外した。 未解消 gap がある場合だけ --known-gap を指定する契約を明記した。
lipluscodex
commented
Aug 1, 2026
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
AI self-review (final)
更新後の commit ff221b8 を issue #7 の acceptance criteria、PR diff、production evidence、CI に対して再確認し、PASS と判定した。
Acceptance criteria
- 本番 D1 の
search_docs/doc_edgesを schema fingerprint 付きで read-only 取得し、各 query のrows_written=0/changes=0/changed_db=falseを検証: PASS - 決定論的 fixture、provenance、欠損 endpoint 集計、最終 payload 全体の credential redaction: PASS
- 実 fixture による ingest / search / time metadata / graph activation / success feedback: PASS
- backfill 後の再取得と coverage 監査: PASS
- 欠損窓 2026-07-08..07-22: 0 rows / 0 commits -> 4 rows / 2 commits
- GitHub patched files と D1 rows: 4 / 4
- 2026-07-06..HEAD: GitHub 36 commits / D1 36 commits
- 最新
c1504a9を D1 / MCP で確認 - global provenance は 1318 rows / 494 commits のまま(初回 backfill 後の取得済み snapshot だったため)
known_gapsは未解消 gap のみ、解消済みなら空配列という契約を requirements / docs / tests / committed provenance で一致: PASS
Review finding resolved
取得例が解消済み #178 を --known-gap に残していた矛盾を ff221b8 で修正し、未解消 gap がある場合のみ指定する例へ揃えた。
Verification
- Local: 21/21 tests PASS
- Eval smoke: PASS (graph MRR 0.5, baseline 0.361111; improved queries 2/3)
- GitHub CI run 30700483524: SUCCESS
- Merge state: CLEAN
- Diff check / worktree: clean
Scope deviation: なし。
Review partition:
- now: blocker なし
- later: github-rag-mcp #178 の tracker state は open のままだが、production data gate は実測で満了しており本 PR の merge blocker ではない
- accepted: D1 は検索用の損失あり snapshot であり、byte-exact history の正本は GitHub とする
Next step: squash mergeし、Closes #7 により issue を自動 close する。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
本番 D1 の
search_docs/doc_edgesから、read-only invariant と schema fingerprint を検証して決定論的 fixture / provenance を生成する取得経路を追加します。実データ fixture で ingest、時系列 metadata、graph activation、success feedback を統合検証し、#178 backfill 後の coverage 比較手順も機械化します。