Skip to content

fix: make frozen artifact hash checks cross-platform - #25

Merged
lipluscodex merged 1 commit into
mainfrom
24-fix-frozen-hash-portability
Aug 2, 2026
Merged

fix: make frozen artifact hash checks cross-platform#25
lipluscodex merged 1 commit into
mainfrom
24-fix-frozen-hash-portability

Conversation

@lipluscodex

Copy link
Copy Markdown
Member

Closes #24
v1 / v2 frozen text artifact のhash照合をraw-first exact LF / CRLF parityへ統一します。
frozen artifactとobserved outcomeは変更せず、fresh Windowsで再現した3 failuresを解消します。

v1 / v2 frozen text artifact の SHA-256 照合を raw-first LF / CRLF parity へ統一した。
frozen artifact と observed result は変更せず、fresh Windows の3 failuresを解消した。
@lipluscodex lipluscodex linked an issue Aug 2, 2026 that may be closed by this pull request
@lipluscodex lipluscodex self-assigned this Aug 2, 2026

@lipluscodex lipluscodex left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lin: 親エージェントのレビューを完了しました。

今回の判断

ブロッカーなし。frozen artifactを変更せずfresh Windows / Linuxのhash監査を一致させる移植性修正として承認します。

確認事項

  • fresh Windows worktreeで修正前3 failuresを再現
  • read_blind_manifest()のprompt検証とobserved artifact testだけを既存raw-first LF / CRLF parityへ統一
  • raw hashを優先し、完全なLF / CRLF変換以外の本文差、mixed newline、bare CRを拒否
  • v1 / v2 fixture、manifest、prompt、packet、judge artifact、resultにdiffなし
  • v2 response、result、holdoutを再実行していない
  • local 88 tests、CI、diff checkが成功し、worktree clean、remote SHA一致

後続課題

なし。Issue #23は本PRをmainへ取り込んでからfull suiteを再実行し、その後にresult-free freezeへ進めます。

今回固定する境界

newline checkout parityだけを許可し、JSON semantic canonicalizationや任意byte normalizationへ拡張しません。

@lipluscodex
lipluscodex merged commit 06446f4 into main Aug 2, 2026
1 check passed
@lipluscodex
lipluscodex deleted the 24-fix-frozen-hash-portability branch August 2, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: make frozen artifact hash checks cross-platform

1 participant