fix: make frozen artifact hash checks cross-platform - #25
Merged
Conversation
v1 / v2 frozen text artifact の SHA-256 照合を raw-first LF / CRLF parity へ統一した。 frozen artifact と observed result は変更せず、fresh Windows の3 failuresを解消した。
lipluscodex
commented
Aug 2, 2026
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
Lin: 親エージェントのレビューを完了しました。
今回の判断
ブロッカーなし。frozen artifactを変更せずfresh Windows / Linuxのhash監査を一致させる移植性修正として承認します。
確認事項
- fresh Windows worktreeで修正前3 failuresを再現
read_blind_manifest()のprompt検証とobserved artifact testだけを既存raw-first LF / CRLF parityへ統一- raw hashを優先し、完全なLF / CRLF変換以外の本文差、mixed newline、bare CRを拒否
- v1 / v2 fixture、manifest、prompt、packet、judge artifact、resultにdiffなし
- v2 response、result、holdoutを再実行していない
- local 88 tests、CI、diff checkが成功し、worktree clean、remote SHA一致
後続課題
なし。Issue #23は本PRをmainへ取り込んでからfull suiteを再実行し、その後にresult-free freezeへ進めます。
今回固定する境界
newline checkout parityだけを許可し、JSON semantic canonicalizationや任意byte normalizationへ拡張しません。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
v1 / v2 frozen text artifact のhash照合をraw-first exact LF / CRLF parityへ統一します。
frozen artifactとobserved outcomeは変更せず、fresh Windowsで再現した3 failuresを解消します。