Repository navigation
fix(mcpb): sync mcp-server bridge type enum to match Worker (patch) - #115
Merged
Merged
Conversation
mcp-server/server/index.js is the stdio bridge installed via .mcpb into Claude Desktop / Claude Code. It carries its own JSON inputSchema that the client validates against before any request is proxied to the Worker. PR #107 expanded Worker-side zod enum to 9 values (adding issue_comment / pr_review / pr_review_comment), but the bridge's enum was not updated, so requests with the new types were rejected client-side long before reaching the Worker. This was the real root cause of #109 (search_issues type=issue_comment being stuck on the 6-value enum). Yesterday's RagMcpAgent -> V2 rename migration (PR #110 / #112) updated the Worker side but the bridge-side validation still blocked requests, so the effect was not visible. V2 deployment is retained; this fix does not roll back that work. Update: - inputSchema.type.enum -> 9 values matching src/mcp.ts - enum description clarifies the three comment-level types - tool-level description widens to mention comments, PR reviews, and inline review comments #109 の真因は DO init() cache ではなく bridge 側の JSON schema が 6 値に 停まっていたこと。PR #107 で Worker 側は 9 値に拡張済みだったが bridge が更新されておらず、client validation でリクエストが弾かれていた。本修正 で bridge を同期する。 Closes #114 Refs #109
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
github-rag-mcp | aeb8758 | Apr 24 2026, 09:36 AM |
liplus-lin-lay
commented
Apr 24, 2026
liplus-lin-lay
left a comment
liplus-lin-lay
left a comment
Member
Author
There was a problem hiding this comment.
AI self-review: #109 の真因訂正。bridge の hard-coded JSON schema を Worker-side zod enum と同値 (9値) に同期。description も 3 comment-level type と tool scope を追加。Workers Builds も含め 3 checks green、auto mode → squash merge。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
Refs #109
#109 の真因訂正。昨日の DO init() cache 仮説は誤り、真犯人は
mcp-server/server/index.jsの JSON inputSchema 側が 6 値のまま PR #107 で更新漏れしていたこと。bridge が client-side validation で新 type を弾いていたため、Worker 側の 9 値化が surface されていなかった。bridge の
inputSchema.type.enumを 9 値に同期し、description も 3 comment-level type を説明する文言に更新。v0.8.1 release 時に
.mcpbが CD で再 build + npm publish されて Claude Desktop 側に配布される。V2 rename の作業 (#110/#112) は Worker 側の schema 更新として正しく稼働しているので roll back しない。