Halscope improvements - #4553
Merged
Merged
Conversation
The selection colors were to bright, so seen almost as white
- change the style of the dotted line - reduce the size of the edge indicator arrow- - swap colors: the trigger arrow now has the color of the channel instead of the trigger line
This describes the setting better and is consistent with the label named "Scale". Further this is the common way how it is labeled on oscilloscopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some simple improvements:
Some style changes:
trigger line:
optimize the colors for selected graphs because they were too bright which was hard to distinguish from white