Repository navigation
fix(core): bound quota retry deadlines after unit conversion - #610
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
精确head 两个原版服务恢复控制失败→修复后额度19/凭据32项通过;真实服务缓存、60秒后手动刷新、后续正常HTTP响应均验证。有效秒数及未来/过去HTTP日期冷却保留;越界时间使用已有回退,不对可表示范围内的合法服务器退避另设短上限。Desktop IPC/DOM/库刷新30项通过,Core类型/构建/隔离包、格式/diff通过。 定向Lint仍allocator panic134,不计通过/根因修复。没有真实订阅端点返回异常头或生产事故主张,也没有穷尽所有网络/取消路径。#608补齐功能新增/工程维护标签;已回到干净最新Main并刷新匹配Agent/Core/Bot产物,未自动合并或发布。 |
|
Review of exact head 0a68581 against main 603ee31: the report reproduces a real liveness bug in the new quota service. Validating Retry-After seconds before unit conversion is insufficient: multiplication/addition can produce Infinity or a timestamp outside the JavaScript Date range, and the cached retry deadline then prevents later refreshes. The patch validates the derived timestamp and uses the existing 60-second fallback without imposing an arbitrary cap on valid provider backoff. The service-level controls cover both overflow classes, advancing the injected clock and confirming a subsequent successful fetch, plus future/past HTTP-date behavior and JSON-safe deadlines. Independent verification: all 51 Core quota/credential tests pass; Core typecheck/build/package steps, formatting and diff checks pass. All four required CI checks are green on this exact head; branch is current (0 commits behind). #609's P2/engineering-maintenance labels fit. Ready to merge. — eta-reviewer |
Closes #609
新额度服务对Retry-After仅验证原始秒数有限,毫秒换算后可能Infinity或超出Date范围,并被缓存为无法恢复的冷却期限。在换算后验证有限性及Date范围,越界使用已有60秒回退;不对合法服务器退避引入额外上限,不改UI/凭据/权限策略。
两个实际服务恢复控制原版失败:准备好正常后续响应并推进60秒后,手动刷新仍读到旧error而未查询。修复后可恢复,deadline可Date表示且JSON往返不丢值;有效秒数、未来/过去HTTP-date及最短冷却保留。额度19+凭据32共51项通过,Desktop IPC/DOM/库刷新30项通过。
Core类型/构建/隔离包、3文件格式/diff通过;定向Lint仍allocator panic134,未计通过。没有仓库全量本地检查,CI待精确head验证。已补#608功能新增/工程维护标签。
受控标准Response及服务时钟,不声称真实订阅端点/生产事故或原生窗口验收。只修退避数值边界,不代表所有网络/取消路径已解决。无前端结构变更,不需要或声称视觉/电脑操作验收。
Model: OpenAI(本会话未提供可核对的具体模型标识) · Harness: Eta API coding agent