dist-check: ignore inlined machine paths (the real chronic-red root cause)#6
Merged
Conversation
Root cause of the chronic red runs (found via run 27339123329 logs): bun inlines __filename/__dirname as absolute string literals for CJS deps (bindings, cbor-extract), so a bundle built on a Mac and CI's Linux rebuild can never be byte-identical. git diff -I now ignores lines differing only by those machine paths; real code changes still fail the guard.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 27339123329 logs show the residual diff is solely bun-inlined absolute __filename/__dirname literals (/Users/... vs /home/runner/...) in the runtime bundles — impossible to be byte-identical across machines. The guard now diffs with -I over those path patterns; genuine code staleness still fails.