Fixes for MMTests scripts#630
Open
manul7 wants to merge 2 commits into
Open
Conversation
added 2 commits
July 1, 2026 14:09
Signed-off-by: Konstantin Belov <konstantin.belov@linaro.org>
- fix dead freq_val variable - always UNKNOWN - remove dead benchmark SHA256 collection - move system info collection after results validation - add empty-benchmarks guard - move RESULTS_OK write to after full loop, not per-benchmark Signed-off-by: Konstantin Belov <konstantin.belov@linaro.org>
roxell
reviewed
Jul 1, 2026
| os.remove(RESULTS_OK) | ||
| log.debug("Removed previous results check file") | ||
| except (OSError, PermissionError) as e: | ||
| log.warning("Failed to remove results check file: %s", e) |
Collaborator
There was a problem hiding this comment.
shouldn't this try except block happen before the the two sys.exit(1) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.