test: ping now responds with pong - #14
Merged
Merged
Conversation
The IPC bridge implements PING -> PONG, so the stale test_ping_not_implemented (asserting no reply) fails on main. Update it to assert a single PONG is sent and no bus events are published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the failing
test (3.11)CI job onmain.The IPC bridge now implements
PING -> PONG(_handle_pingsends a pong),but
test_ping_not_implementedstill asserted no reply was sent, so it failedafter the merge. Renamed it to
test_ping_responds_with_pongand updated theassertions: a single
PONGis sent, and no bus events are published.Verification
cd runtime && uv run python -m pytest→ 64 passeduv run ruff check ./uv run ruff format --check .→ clean