Repository navigation
Fix LearningRateMonitor crash for optimizers without weight decay - #22036
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
October 20, 2026 10:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LearningRateMonitor(log_weight_decay=True)raisesKeyError: 'weight_decay'when the optimizer has noweight_decaykey in its param groups, for exampletorch.optim.Rprop,torch.optim.LBFGSortorch.optim.SparseAdam.This change reads the value with
param_group.get("weight_decay", 0), which matches howlog_momentum=Truealready logs0for optimizers without momentum. A param group withoutweight_decayapplies no weight decay, so0is the accurate value.The new test
test_log_weight_decay_no_weight_decay_optimizertrains aBoringModelwithRprop. It fails withKeyErroron master and passes with this change.Fixes #22035
No breaking changes.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist