Repository navigation
fix(checkpoint): avoid overwriting checkpoint after resume - #22034
Open
wpyaoxueros wants to merge 2 commits into
Open
wpyaoxueros wants to merge 2 commits into
wpyaoxueros wants to merge 2 commits into
Conversation
wpyaoxueros
marked this pull request as ready for review
October 19, 2026 22:44
wpyaoxueros
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
October 19, 2026 22:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When resuming with
accumulate_grad_batches > 1,ModelCheckpointstarts with an empty last-saved-step marker even though the restored trainer is already at a checkpointedglobal_step. The first resumed batch can therefore save that same step again before an optimizer update, overwriting the checkpoint with later loop progress. Initialize the guard from the restored trainer step when a checkpoint was loaded.Fixes #22033
Validation
(global_step=2, batches_completed=3)to(2, 4).(2, 3)and the original CPU-only reproduction shows weights resumed from the saved checkpoint matching uninterrupted training.pytest --confcutdir=tests/tests_pytorch/callbacks -q tests/tests_pytorch/callbacks/test_model_checkpoint_edge_cases.py: 3 passed.AI disclosure: Codex assisted with reproducing the bug, implementing the fix, and writing the regression test.