Skip to content

ci: pin runner images to ubuntu-24.04, macos-26, windows-2025 #22010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhimrazy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ci: pin runner images to ubuntu-24.04, macos-26, windows-2025 #22010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fa1916
ci: pin runner images to ubuntu-24.04, macos-26, windows-2025
bhimrazy Oct 7, 2026
27f45bc
ci: add runner images reference
bhimrazy Oct 7, 2026
096c7f7
ci: run macOS test matrices on macos-15 and relax hooks doctest
bhimrazy Oct 12, 2026
ee017a6
ci: run macOS tests as root to avoid ~35s DNS stall per process group…
bhimrazy Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/_build-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ defaults:

jobs:
build-packages:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
matrix:
pkg-name: ${{ fromJSON(inputs.pkg-names) }}
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:

merge-artifacts:
needs: build-packages
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with: # download all build artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_legacy-checkpoints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ defaults:

jobs:
create-legacy-ckpts:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
pl-version: ${{ steps.decide-version.outputs.pl-version }}
steps:
Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
aws s3 cp $AWS_RUN checkpoints.zip s3://pl-public-data/legacy/ --acl public-read

add-ckpt-test:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: inputs.create_pr
needs: create-legacy-ckpts
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pkg-install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-22.04", "macOS-14", "windows-2022"]
os: ["ubuntu-24.04", "macos-26", "windows-2025"]
pkg-name: ["fabric", "pytorch", "lightning", "notset"]
python-version: ["3.10", "3.11"]
env:
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/ci-tests-fabric.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macOS-14, ubuntu-22.04, windows-2022]
os: [macos-26, ubuntu-24.04, windows-2025]
config:
# Test unified "lightning" package at the oldest supported and the latest PyTorch
- { pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.6" }
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
FREEZE_REQUIREMENTS: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}
TORCH_URL_STABLE: "https://download.pytorch.org/whl/cpu/"
# TODO: Remove this - Enable running MPS tests on this platform
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}
DISABLE_MPS: ${{ startsWith(matrix.os, 'macos') && '1' || '0' }}
UV_TORCH_BACKEND: "cpu"
# Supply-chain guard: skip PyPI releases newer than this. See https://docs.astral.sh/uv/reference/settings/#exclude-newer
UV_EXCLUDE_NEWER: "2 days"
Expand Down Expand Up @@ -154,9 +154,12 @@ jobs:
- name: Testing Fabric
working-directory: tests/tests_fabric
# NOTE: do not include coverage report here, see: https://github.com/nedbat/coveragepy/issues/1003
# On macOS 15+ runners, Local Network Privacy blocks mDNS for non-root processes, so every
# hostname/reverse-DNS lookup (e.g. torch's TCPStore connect) stalls ~35s; root is exempt.
# See https://github.com/actions/runner-images/issues/14568 and https://github.com/actions/runner-images/issues/10924
run: |
echo $GITHUB_RUN_ID
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
${{ runner.os == 'macOS' && 'sudo -E env "PATH=$PATH"' || '' }} python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
-m pytest -v --timeout=60 --durations=50 --random-order-seed=$GITHUB_RUN_ID \
--junitxml=junit.xml -o junit_family=legacy # NOTE: for Codecov's test results

Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/ci-tests-pytorch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macOS-14, ubuntu-22.04, windows-2022]
# Runner images: https://github.com/actions/runner-images
os: [macos-26, ubuntu-24.04, windows-2025]
config:
# Test unified "lightning" package at the oldest supported and the latest PyTorch
- { pkg-name: "lightning", python-version: "3.10", pytorch-version: "2.6" }
Expand Down Expand Up @@ -72,7 +73,7 @@ jobs:
TORCH_URL: "https://download.pytorch.org/whl/cpu/"
FREEZE_REQUIREMENTS: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}
# TODO: Remove this - Enable running MPS tests on this platform
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}
DISABLE_MPS: ${{ startsWith(matrix.os, 'macos') && '1' || '0' }}
UV_TORCH_BACKEND: "cpu"
# Supply-chain guard: skip PyPI releases newer than this. See https://docs.astral.sh/uv/reference/settings/#exclude-newer
UV_EXCLUDE_NEWER: "2 days"
Expand Down Expand Up @@ -184,9 +185,12 @@ jobs:
- name: Testing PyTorch
working-directory: tests/tests_pytorch
# NOTE: do not include coverage report here, see: https://github.com/nedbat/coveragepy/issues/1003
# On macOS 15+ runners, Local Network Privacy blocks mDNS for non-root processes, so every
# hostname/reverse-DNS lookup (e.g. torch's TCPStore connect) stalls ~35s; root is exempt.
# See https://github.com/actions/runner-images/issues/14568 and https://github.com/actions/runner-images/issues/10924
run: |
echo $GITHUB_RUN_ID
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
${{ runner.os == 'macOS' && 'sudo -E env "PATH=$PATH"' || '' }} python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
-m pytest . -v --timeout=90 --durations=50 --random-order-seed=$GITHUB_RUN_ID \
--junitxml=junit.xml -o junit_family=legacy # NOTE: for Codecov's test results

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ defaults:

jobs:
mypy:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
env:
UV_TORCH_BACKEND: "cpu"
# Supply-chain guard: skip PyPI releases newer than this. See https://docs.astral.sh/uv/reference/settings/#exclude-newer
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ env:
jobs:
docs-make:
if: github.event.pull_request.draft == false
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
deploy-docs:
needs: docs-make
if: github.repository_owner == 'Lightning-AI' && github.event_name != 'pull_request'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs-tutorials.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ defaults:

jobs:
docs-update:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ defaults:

jobs:
build-packages:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
env:
PKG_NAME: "lightning"
# Supply-chain guard: skip PyPI releases newer than this (ISO 8601 duration). See https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-uploaded-prior-to
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release-pkg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
artifact-name: dist-packages-${{ github.sha }}

upload-packages:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: build-packages
if: github.event_name == 'release'
steps:
Expand All @@ -49,7 +49,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

release-version:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
tag: ${{ steps.lai-package.outputs.version }}
steps:
Expand All @@ -66,7 +66,7 @@ jobs:
run: python -c "import lightning ; print(f'version={lightning.__version__}')" >> $GITHUB_OUTPUT

signaling:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: ["release-version", "build-packages"]
if: startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release'
env:
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
borda

publish-packages:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [build-packages]
if: startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release'
permissions:
Expand Down
2 changes: 1 addition & 1 deletion docs/source-pytorch/common/hooks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ important to understand. The following order is always used:
...
Callback: Training is starting!
Model: Training is starting!
Epoch 0/0 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 64/64 ...
Epoch 0/0 ...


.. note::
Expand Down
Loading