[littlebullGit]

When resuming from a checkpoint with reload_dataloaders_every_n_epochs, the dataloader was not being reloaded at the correct epoch. This was because setup_data() was overwriting _last_train_dl_reload_epoch with the current epoch during checkpoint restoration, losing the information about when the dataloader was actually last reloaded.

The fix:

1. Save _last_train_dl_reload_epoch in checkpoint state
2. Restore _last_train_dl_reload_epoch from checkpoint on load
3. Only update _last_train_dl_reload_epoch when actually reloading the dataloader or during initial setup (not when resuming)

This ensures _should_reload_train_dl returns the correct value after resuming from a checkpoint.

Backward compatible: old checkpoints without this key will default to float('-inf'), which triggers a reload (the safest behavior).

Fixes #21492

---

📚 Documentation preview 📚: https://pytorch-lightning--21514.org.readthedocs.build/en/21514/

[codecov]

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (7983ecb) to head (234f734).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (7983ecb) and HEAD (234f734). Click for more details.

HEAD has 546 uploads less than BASE

Flag	BASE (7983ecb)	HEAD (234f734)
python3.10	12	3
cpu	168	42
lightning	60	15
pytest	84	0
lightning_fabric	54	0
python3.12	48	12
python	12	3
python3.11	24	6
python3.13	36	9
python3.12.7	36	9
pytorch_lightning	54	27
pytorch2.7	6	3
pytest-full	84	42
pytorch2.3	6	3
pytorch2.1	12	6
pytorch2.9	12	6
pytorch2.8	12	6
pytorch2.5.1	6	3
pytorch2.2.2	6	3
pytorch2.10	12	6
pytorch2.6	6	3
pytorch2.4.1	6	3

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #21514     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       23888    23846     -42     
=========================================
- Hits        20668    18777   -1891     
- Misses       3220     5069   +1849     

[littlebullGit]

@SkafteNicki @Borda @deependujha Can you take a look of this PR ?

[deependujha]

Hi @littlebullGit, thanks for the fix and for the PR.

The fix itself looks neat. I’m a bit mixed on the tests, though: they’re very thorough, but they also feel a bit verbose/heavy for the behavior we’re trying to validate.

Do you think we could simplify them without losing coverage?

My concern is this test touches too many parts and seems more like integration test, which might become less maintainable. But, if no easier way to verify seem suitable, it will be fine.

[littlebullGit]

Hi @littlebullGit, thanks for the fix and for the PR.

The fix itself looks neat. I’m a bit mixed on the tests, though: they’re very thorough, but they also feel a bit verbose/heavy for the behavior we’re trying to validate.

Do you think we could simplify them without losing coverage?

My concern is this test touches too many parts and seems more like integration test, which might become less maintainable. But, if no easier way to verify seem suitable, it will be fine.

@deependujha , thank you for the feedback. Good point. I agreed the original test was too integration heavy. I have simplified the test now just records the train_dataloader() call epochs and asserts the expected sequence. Please take a look.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (84df182) to head (e9aa1bc).
✅ All tests successful. No failed tests found.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (84df182) and HEAD (e9aa1bc). Click for more details.

HEAD has 13016 uploads less than BASE

Flag	BASE (84df182)	HEAD (e9aa1bc)
cpu	2962	51
lightning_fabric	1356	0
pytest	1539	0
python3.12	1232	21
python3.12.7	173	3
python3.13	1199	21
python	177	3
lightning	353	6
python3.10	181	3
pytorch_lightning	1253	45
pytorch2.6	252	9
pytest-full	1423	51
pytorch2.12	173	6
pytorch2.7	87	3
pytorch2.9	163	6
pytorch2.8	163	6
pytorch2.13	257	9
pytorch2.10	163	6
pytorch2.11	165	6

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #21514     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       24015    23973     -42     
=========================================
- Hits        20855    18841   -2014     
- Misses       3160     5132   +1972