Skip to content

Initial Starcatcher integration fixes#56

Open
Silvertide7 wants to merge 5 commits into
Lightning-64:mainfrom
Silvertide7:main
Open

Initial Starcatcher integration fixes#56
Silvertide7 wants to merge 5 commits into
Lightning-64:mainfrom
Silvertide7:main

Conversation

@Silvertide7

@Silvertide7 Silvertide7 commented Jun 23, 2026

Copy link
Copy Markdown

Love the new compat! It had a few issues though, the largest of which being the compat doesn't work on a dedicated server because of a minecraft.client import. The others are just integrating more functionality from Starcatcher, like journal entries and tournament scoring.

  • Tide rod catches now count in Starcatcher's tournaments, golden fish, and guide.
  • New config option (fishDataSource) to pick whether caught fish use Tide's data or Starcatcher's data.
  • Starcatcher hats and accessories now affect the minigame.
  • Perfect catches now register as perfect.

Couple extra finds

  • Fixed the Fabric build, which wasn't compiling.
  • Fixed a crash when giving out a Starcatcher fish, fixed Tide's journal wiping your biggest catch record, and cleaned up a small memory leak.

@Silvertide7

Copy link
Copy Markdown
Author

Just wanted to ping this in case it lost visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant