Skip to content

Generate 1.27mm tht headers and sockets - #63

Open
RX14 wants to merge 3 commits into
LibrePCB:masterfrom
RX14:feature/1.27mm-parts
Open

Generate 1.27mm tht headers and sockets#63
RX14 wants to merge 3 commits into
LibrePCB:masterfrom
RX14:feature/1.27mm-parts

Conversation

@RX14

@RX14 RX14 commented Nov 20, 2019

Copy link
Copy Markdown

The drill sizes i got from various datasheets and seem the right ballpark. The pad sizes are the largest I can fit without getting DRC errors for being too close to the silkscreen...

@RX14
RX14 force-pushed the feature/1.27mm-parts branch 3 times, most recently from 10ace75 to 2622444 Compare November 20, 2019 22:58

@rnestler rnestler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some flake8 issues and the pipenv stuff. Other than that I'd need to look at it more deeply and especially verify if it doesn't change all the other headers and sockets.

Comment thread Pipfile Outdated
@RX14

RX14 commented Nov 22, 2019

Copy link
Copy Markdown
Author

Whoops! I was pretty sure I'd not committed the pipfile, and I had committed the flake8 changes!

Must have sleepily staged the pipfile instead of the python file...

Anyway, all fixed.


I have verified that it doesn't change all the other headers and sockets - apart from the metadata (tags list). Here's an example diff:

@RX14
RX14 force-pushed the feature/1.27mm-parts branch from 2622444 to 688671e Compare November 22, 2019 00:13
@rnestler
rnestler requested a review from dbrgn April 20, 2020 12:17
@rnestler

Copy link
Copy Markdown
Member

@RX14 Sorry that this got stale.

@dbrgn How could we test this? Check if the old connectors still get created the same seems to make sense.

@RX14

RX14 commented Apr 22, 2020

Copy link
Copy Markdown
Author

I checked that it doesn't change the other headers apart from metadata. You can see the diff above and check for yourself if you don't trust me!

I'm also happy to rebase this and re-test.

@rnestler

Copy link
Copy Markdown
Member

I checked that it doesn't change the other headers apart from metadata. You can see the diff above and check for yourself if you don't trust me!

No, if somebody tested it we should be fine 🙂

@RX14 RX14 closed this Apr 11, 2021
@dbrgn

dbrgn commented Apr 11, 2021

Copy link
Copy Markdown
Member

@RX14 sorry for the long delays in reviewing. You don't need to close it, we will take a look sometime 🙂

@dbrgn dbrgn reopened this Apr 11, 2021
@RX14

RX14 commented Apr 11, 2021

Copy link
Copy Markdown
Author

That's fine, but be aware that I'm not so interested in addressing reviews any more though, so any reviews will have to be addressed yourself

@dbrgn

dbrgn commented Apr 11, 2021

Copy link
Copy Markdown
Member

That's fine, but be aware that I'm not so interested in addressing reviews any more though, so any reviews will have to be addressed yourself

Sure, that's perfectly fine. You don't owe us anything (thanks for the contribution so far), so if it's fine for you we can take over once one of us finds time to review your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants