Fix entities module dependencies to main common file - #180
Merged
Conversation
Move all identifiers used in entities/* from common.py to entities/helper.py Rationale: Sub-packages should not depend on files of the parent hierarchy. Previously, files in entities used absolute import "common" which is ambiguous in some contexts.
ubruhin
force-pushed
the
fix-module-dependencies
branch
from
August 11, 2026 08:19
54576c0 to
3f1315c
Compare
ubruhin
requested changes
Aug 11, 2026
ubruhin
left a comment
ubruhin
left a comment
Member
There was a problem hiding this comment.
Thanks - I think generally this change makes sense. I have rebased this branch to master to ensure some additional checks are run on CI.
Currently I see two issues:
STRING_ESCAPE_SEQUENCESis now duplicated- CI is failing due to code formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all identifiers used in entities/* from common.py to entities/helper.py
Rationale: Sub-packages should not depend on files of the parent hierarchy.
Previously, files in entities used absolute import "common" which is ambiguous in some contexts.