Skip to content

Add ATmega4809 - #13

Open
doom-fr wants to merge 13 commits into
LibrePCB-Libraries:masterfrom
doom-fr:add-ATmega4809
Open

Add ATmega4809#13
doom-fr wants to merge 13 commits into
LibrePCB-Libraries:masterfrom
doom-fr:add-ATmega4809

Conversation

@doom-fr

@doom-fr doom-fr commented May 31, 2020

Copy link
Copy Markdown
SUMMARY

Add ATmmega4809 device

OPEN QUESTIONS / UNRESOLVED ISSUES
CHECKLIST
  • I have read and followed the library conventions.
  • For packages, I followed IPC7351C (see details in library conventions).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License, allowing everyone to use and modify the content without any restrictions.

@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Jun 1, 2020

@dbrgn dbrgn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you have changed the file permissions of many pre-existing files (like the README) from 644 to 755. Can you undo that change before we carry on with the review? (Let me know if you need help with that...)

@dbrgn dbrgn added needs corrections Pull request needs corrections before next review. and removed ready for review Waiting for review by maintainers. labels Oct 1, 2020
@doom-fr

doom-fr commented Oct 4, 2020

Copy link
Copy Markdown
Author

Do not remember this change.
What should be rights ? All files and folders to 644 ? Only files ?

@dbrgn

dbrgn commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

Files should probably have 644 as permission. Folders need 755, but they aren't tracked by git, so it doesn't matter.

@doom-fr

doom-fr commented Oct 4, 2020

Copy link
Copy Markdown
Author

Done !

@dbrgn dbrgn added ready for review Waiting for review by maintainers. and removed needs corrections Pull request needs corrections before next review. labels Oct 4, 2020
@doom-fr

doom-fr commented Jan 30, 2021

Copy link
Copy Markdown
Author

Hi @dbrgn can you check this ?
I need to update this lib today and as I am not comfortable with git, I think it will be easier if you merge this pull request before.

@doom-fr
doom-fr requested a review from dbrgn January 31, 2021 22:54
@dbrgn

dbrgn commented Jan 31, 2021

Copy link
Copy Markdown
Collaborator

I'll try to take a look at this in the coming week, if I find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New library element. ready for review Waiting for review by maintainers.

Development

Successfully merging this pull request may close these issues.

3 participants