Skip to content

Add more attributes to capacitor components - #138

Draft
ubruhin wants to merge 1 commit into
masterfrom
137-more-capacitor-attributes
Draft

Add more attributes to capacitor components#138
ubruhin wants to merge 1 commit into
masterfrom
137-more-capacitor-attributes

Conversation

@ubruhin

@ubruhin ubruhin commented Apr 25, 2024

Copy link
Copy Markdown
Contributor
SUMMARY
  • Add attributes RATED_VOLTAGE (unipolar + bipolar) and DIELECTRIC (bipolar only).
  • Also add these attributes to the component's default value to make them appear in schematics

Closes #137

DATASHEETS / REFERENCES

None

OPEN QUESTIONS / UNRESOLVED ISSUES

The schematic editor does not handle the new default value very well when adding new capacitors to the schematic, thus we should not merge this yet...

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

- Add attributes VOLTAGE_RATING (unipolar + bipolar) and DIELECTRIC
  (bipolar only).
- Also add these attributes and MPN to the component's default value
  to make them appear in schematics
@ubruhin
ubruhin force-pushed the 137-more-capacitor-attributes branch from c9b5b41 to a02389d Compare May 29, 2026 22:02
@eduardosm

Copy link
Copy Markdown
Contributor

The schematic editor does not handle the new default value very well when adding new capacitors to the schematic, thus we should not merge this yet...

Has this been fixed by LibrePCB/LibrePCB#1807?

@ubruhin

ubruhin commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

Has this been fixed by LibrePCB/LibrePCB#1807?

I think so, thus I just updated this PR yesterday. I'll need to test, review and think about this again to decide if it is now ready to merge.

Also I think we should still wait a bit with merging this. There are still many people using LibrePCB 2.0. With this version, it would be bad to get the updated capacitors as the editor won't behave nicely with it. It's not a big deal for less used components, but the capacitor is one of the most used component so it would be very bad user experience.

Packaging status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add voltage rating value in the symbol of capacitor

2 participants