refactor(reservations): initialize reservation with rendered $StartDa…#1529
Merged
JohnVillalovos merged 1 commit intoJul 8, 2026
Merged
Conversation
…te and $EndDate - Replace the use of values read from #BeginDate and #EndDate with dates rendered by Smarty, avoiding reliance on the DOM state during reservation initialization. - Maintains consistency with Reservation/create.tpl - Avoids the use of jQuery
JohnVillalovos
approved these changes
Jul 8, 2026
JohnVillalovos
left a comment
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @labmecanicatec
Makes sense to me.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors reservation initialization in the reservation view template to use server-rendered $StartDate / $EndDate values (formatted via Smarty) instead of reading #BeginDate/#EndDate from the DOM at init time, aligning the approach with Reservation/create.tpl.
Changes:
- Replace DOM-derived
startStr/endStrconstruction with{format_date ... key=system_datetime}values passed directly intoreservation.init(...). - Remove the two jQuery
.val()reads for initialization-time date construction intpl/Reservation/view.tpl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te and $EndDate