fix(ics): format subscription feeds with privacy-aware session#1472
Draft
JohnVillalovos wants to merge 2 commits into
Draft
fix(ics): format subscription feeds with privacy-aware session#1472JohnVillalovos wants to merge 2 commits into
JohnVillalovos wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ICS subscription/export behavior so reservation label formatting can be applied in subscription feeds while still respecting privacy filtering, and restructures how reservation text is mapped into iCalendar fields.
Changes:
- Build a “logged-in but ownerless” user session for anonymous uid-based subscription requests to allow label formatting code paths to run.
- Move configured ICS label formatting into
SUMMARY, and use reservation notes forDESCRIPTIONwith newline escaping for RFC 5545 TEXT. - Add PHPUnit coverage around iCalendar reservation view summary/description behavior and newline escaping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
Presenters/CalendarSubscriptionPresenter.php |
Adjusts session handling for anonymous uid subscription requests. |
lib/Application/Schedule/iCalendarReservationView.php |
Changes which reservation fields populate SUMMARY vs DESCRIPTION and adds newline escaping for DESCRIPTION. |
tests/Presenters/CalendarExportPresenterTest.php |
Adds tests for formatted summary, description sourcing, and newline escaping behavior. |
tests/Presenters/CalendarSubscriptionPresenterTest.php |
Minor formatting-only change (trailing newline). |
JohnVillalovos
force-pushed
the
jlvillal/fiu-02
branch
from
53c4532 to
b2fc26e
Compare
JohnVillalovos
force-pushed
the
jlvillal/fiu-02
branch
from
b2fc26e to
4de1ca8
Compare
JohnVillalovos
force-pushed
the
jlvillal/fiu-02
branch
2 times, most recently
from
b782b5e to
a5ac463
Compare
Add an explicit skipVisibilityChecks argument to SlotLabelFactory::Format for callers that have already authorized reservation details. Keep the default path unchanged and keep NullSlotLabelFactory fail-closed. Assisted-by: Codex:GPT-5
JohnVillalovos
force-pushed
the
jlvillal/fiu-02
branch
from
a5ac463 to
6674c85
Compare
Add explicit iCalendar view options for anonymous public subscriptions and user-scoped subscription URLs. Keep anonymous requests anonymous while allowing user subscription URLs to format with the subscribed user context. Assisted-by: Codex:GPT-5
JohnVillalovos
force-pushed
the
jlvillal/fiu-02
branch
from
6674c85 to
7d65024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an ownerless logged-in session for anonymous uid subscription requests so ICS label formatting can run while privacy hide flags still apply.
Move the configured ICS label formatting into the iCalendar SUMMARY field and use reservation notes for DESCRIPTION, escaping embedded newlines for RFC 5545 text values.
Assisted-by: Claude:claude-sonnet-4-6