feat: parameterize Docker images in docker-compose-local.yml#214
Conversation
|
forgot to add the env variables to docker-compose-public.yml. |
|
Hi @inDane , thank you very much for your PR. Although your suggestion only applies to docker-compose.yml files, I like it. I just made a test on Windows 11, for I was unsure how it would handle the variable substitutions, and it worked nonetheless. To approve the PR, you will need to change the name of the variables, so that they don't start with |
Hi @colisee, Best |
|
Sorry to bother you one last time, but since your env variables start with |
OK, i think would be the best variant. OK with you? |
|
Fine with me. The only reason I used |
|
i see, but if someone was to build LXC or any other container variant for this, it wouldnt be precise. But honestly I dont have hard feelings for any naming scheme. If you want CONTAINER, i put CONTAINER ;D |
|
Don't worry: please proceed with your naming scheme |
What
Adds
DOCKER_*_IMAGEandDOCKER_*_TAGenvironment variables so the DB and app images indocker-compose-local.ymlcan be overridden without modifying the compose file.Why
Variables
DOCKER_DB_IMAGEmy.registry.example.com/hub.docker.com/linuxserver/mariadbDOCKER_DB_TAG10.6.13DOCKER_APP_IMAGEmy.registry.example.com/hub.docker.com/librebooking/librebookingDOCKER_APP_TAG5.1.0DOCKER_PROXY_IMAGEmy.registry.example.com/hub.docker.com/nginxproxy/nginx-proxyDOCKER_PROXY_TAGlatestDOCKER_ACME_IMAGEmy.registry.example.com/hub.docker.com/nginxproxy/acme-companionDOCKER_ACME_TAGlatestBackward compatible