Skip to content

fix: apply the download_file stub to moon_engine too (#160) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeyckerS merged 1 commit into from
Aug 12, 2026
Merged

fix: apply the download_file stub to moon_engine too (#160) #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ async def fake_shutdown_chrome():
monkeypatch.setattr(moon_extract, "shutdown_chrome", fake_shutdown_chrome)

for host in (moon_engine, moon_cli):
# Every stub in this loop must cover both moon_engine and moon_cli. Break that and the engine keeps the real function — it will actually try to make network requests, because monkeypatch never replaced its download_file.
monkeypatch.setattr(host, "extract_fuckingfast", fake_ff)
monkeypatch.setattr(host, "extract_datanodes", fake_dn)
monkeypatch.setattr(host, "close_ff_session", lambda: asyncio.sleep(0))
monkeypatch.setattr(moon_cli, "download_file", fake_download)
monkeypatch.setattr(host, "download_file", fake_download)

return calls