Skip to content

fix(tests): return actual download count in run_cli to catch missing output files #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snushev wants to merge 1 commit into from
Closed

fix(tests): return actual download count in run_cli to catch missing output files #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/test_no_chrome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Network, extraction and Chrome are stubbed at the moon_extract level: what is
under test is the dispatcher's decision to launch, not the extractors.
"""

from __future__ import annotations

import asyncio
Expand Down Expand Up @@ -53,7 +54,7 @@ def run_cli(urls, retries=1) -> dict:
with tempfile.TemporaryDirectory() as out:
asyncio.run(moon_cli.run(urls, out, 4, 4, retries, "proxies.txt"))
done = len(os.listdir(out))
return {"ok": len(urls) if done == 0 else done, "fail": 0}
return {"ok": done, "fail": len(urls) - done}


def assert_browser_counts(result, calls, urls, want_browsers: int) -> None:
Expand Down
Loading