Skip to content

Sync runtime-required English catalog with en.json - #35

Closed
svc-orca[bot] wants to merge 1 commit into
mainfrom
fix/i18n-runtime-catalog-sync
Closed

svc-orca[bot] wants to merge 1 commit into
mainfrom
fix/i18n-runtime-catalog-sync

Conversation

@svc-orca

@svc-orca svc-orca Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​10 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9

ELI5

The renderer ships a trimmed-down English string file for boot. It still carried seven
leftover strings for a terminal "minimum contrast" setting that no longer exists in the
full English catalog. CI checks those two files agree, so every build failed. This
regenerates the trimmed file with the repo's own script.

What Changed

Regenerated src/renderer/src/i18n/en-runtime-required.json via
pnpm run sync:localization-runtime-catalog.

Net effect: the stale auto.components.settings.TerminalPane.minimumContrast.* subtree
(7 keys: automatic, description, disabled, pinned, placeholder, suffix,
title) is dropped. One file, +1 / -10, data only — no source, config, or test changes.

Those keys no longer exist anywhere under auto.components.settings.TerminalPane in
src/renderer/src/i18n/locales/en.json; the live call sites in
src/renderer/src/components/settings/terminal-typography-search.ts use the
auto.components.settings.terminal.search.minimumContrast.* namespace instead. The
removed entries were pure residue, so nothing user-visible is lost.

Why

Pre-existing, deterministic drift on main — not introduced by any open PR.

Reproduced on a clean worktree checked out directly from origin/main (no local
changes), before this commit:

$ pnpm run verify:localization-runtime-catalog
src/renderer/src/i18n/en-runtime-required.json no longer covers en.json.

Shipped entries whose text disagrees with en.json:
  auto.components.settings.TerminalPane.minimumContrast.automatic
  auto.components.settings.TerminalPane.minimumContrast.description
  auto.components.settings.TerminalPane.minimumContrast.disabled
  auto.components.settings.TerminalPane.minimumContrast.pinned
  auto.components.settings.TerminalPane.minimumContrast.placeholder
  auto.components.settings.TerminalPane.minimumContrast.suffix
  auto.components.settings.TerminalPane.minimumContrast.title

Run `pnpm run sync:localization-runtime-catalog` to regenerate it.
[ELIFECYCLE] Command failed with exit code 1.

This blocks the Verify runtime-required localization catalog step in
.github/workflows/pr.yml and fails src/renderer/src/i18n/runtime-required-catalog.test.ts
for every PR against main. The fix is exactly the remediation the tool itself prints,
so the diff is mechanical rather than hand-authored.

Linked Issue

No tracking issue — CI-blocking drift found while running checks on an unrelated PR.

Visual Proof

N/A — the removed keys are unreferenced catalog residue. The strings they held are not
rendered by any call site, so there is no before/after UI state to capture.

Testing

Run from a worktree off origin/main on Linux:

pnpm run sync:localization-runtime-catalog
# Wrote 1680 of 14189 English entries to en-runtime-required.json.

pnpm run verify:localization-runtime-catalog
# en-runtime-required.json covers en.json: 1680 of 14189 English entries must ship in the boot bundle.

npx vitest run src/renderer/src/i18n/runtime-required-catalog.test.ts
# Test Files  1 passed (1) | Tests  22 passed (22)

npx tsc --noEmit -p config/tsconfig.tc.web.json
# clean (renderer project; covers the changed JSON)

All four pass after the change; the first two and the vitest file fail on main without it.

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

No new tests: runtime-required-catalog.test.ts and the CI verify step already guard this
invariant. They were failing; they now pass. A new test would duplicate an existing gate.

AI Disclosure

Claude (Anthropic) assisted with reproduction and this write-up. The catalog change itself
is the verbatim output of the repo's sync:localization-runtime-catalog script.

Review

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Ensure no issues in: Security, Cross-platoform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance

Data-only change to a generated English boot catalog. No platform-, SSH-, or mobile-specific
surface. Marginally smaller boot bundle. Non-English locales are untouched.

Checklist

  • This PR is small and focused
  • I explained what changed and why (including ELI5)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Ran the targeted checks listed under Testing rather than the full suites; CI covers the rest.

`en-runtime-required.json` still shipped seven
`auto.components.settings.TerminalPane.minimumContrast.*` entries that no
longer exist in `en.json`, so `pnpm run verify:localization-runtime-catalog`
failed on main. Regenerate the subset with the repo's own sync script.
@svc-orca

svc-orca Bot commented Oct 9, 2026

Copy link
Copy Markdown
Author

Superseded by upstream PR stablyai#19575 which has been merged.

@svc-orca svc-orca Bot closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant