Repository navigation
Sync runtime-required English catalog with en.json - #35
Closed
svc-orca[bot] wants to merge 1 commit into
Closed
svc-orca[bot] wants to merge 1 commit into
svc-orca[bot] wants to merge 1 commit into
Conversation
`en-runtime-required.json` still shipped seven `auto.components.settings.TerminalPane.minimumContrast.*` entries that no longer exist in `en.json`, so `pnpm run verify:localization-runtime-catalog` failed on main. Regenerate the subset with the repo's own sync script.
Author
|
Superseded by upstream PR stablyai#19575 which has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The renderer ships a trimmed-down English string file for boot. It still carried seven
leftover strings for a terminal "minimum contrast" setting that no longer exists in the
full English catalog. CI checks those two files agree, so every build failed. This
regenerates the trimmed file with the repo's own script.
What Changed
Regenerated
src/renderer/src/i18n/en-runtime-required.jsonviapnpm run sync:localization-runtime-catalog.Net effect: the stale
auto.components.settings.TerminalPane.minimumContrast.*subtree(7 keys:
automatic,description,disabled,pinned,placeholder,suffix,title) is dropped. One file,+1 / -10, data only — no source, config, or test changes.Those keys no longer exist anywhere under
auto.components.settings.TerminalPaneinsrc/renderer/src/i18n/locales/en.json; the live call sites insrc/renderer/src/components/settings/terminal-typography-search.tsuse theauto.components.settings.terminal.search.minimumContrast.*namespace instead. Theremoved entries were pure residue, so nothing user-visible is lost.
Why
Pre-existing, deterministic drift on
main— not introduced by any open PR.Reproduced on a clean worktree checked out directly from
origin/main(no localchanges), before this commit:
This blocks the
Verify runtime-required localization catalogstep in.github/workflows/pr.ymland failssrc/renderer/src/i18n/runtime-required-catalog.test.tsfor every PR against
main. The fix is exactly the remediation the tool itself prints,so the diff is mechanical rather than hand-authored.
Linked Issue
No tracking issue — CI-blocking drift found while running checks on an unrelated PR.
Visual Proof
N/A— the removed keys are unreferenced catalog residue. The strings they held are notrendered by any call site, so there is no before/after UI state to capture.
Testing
Run from a worktree off
origin/mainon Linux:All four pass after the change; the first two and the vitest file fail on
mainwithout it.No new tests:
runtime-required-catalog.test.tsand the CI verify step already guard thisinvariant. They were failing; they now pass. A new test would duplicate an existing gate.
AI Disclosure
Claude (Anthropic) assisted with reproduction and this write-up. The catalog change itself
is the verbatim output of the repo's
sync:localization-runtime-catalogscript.Review
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
Ensure no issues in: Security, Cross-platoform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance
Data-only change to a generated English boot catalog. No platform-, SSH-, or mobile-specific
surface. Marginally smaller boot bundle. Non-English locales are untouched.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)Ran the targeted checks listed under Testing rather than the full suites; CI covers the rest.