fix(ci): correct JFrog domain and remove unnecessary runner guard - #18
Merged
Conversation
- jfrog.ledgerlabs.net is the correct domain (not ledgerhq.jfrog.io) - public-ledgerhq-shared-medium can reach JFrog via OIDC Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the manual sandbox publish GitHub Actions workflow used to E2E-validate the JFrog publish pipeline, aligning it with the correct JFrog domain and a working publish invocation.
Changes:
- Update the default sandbox registry domain to
jfrog.ledgerlabs.net. - Remove the
RELEASE_RUNNERpresence guard so the workflow can run on the fallback runner. - Fix the publish step to run Changesets publish directly with the
sandboxdist-tag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gre-ledger
marked this pull request as ready for review
July 20, 2026 12:43
ysitbon
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
pnpm changelog) — N/A (CI-only, no library touched)pnpm build && pnpm typecheck && pnpm lint && pnpm testpass locally — N/A📝 Description
Two fixes to the sandbox publish workflow:
1. Wrong JFrog domain —
ledgerhq.jfrog.io→jfrog.ledgerlabs.netConfirmed from
ledger-liveworkflows (publish-wallet-cli-npm.yml,test-coin-tester.yml).2. Removed
RELEASE_RUNNERguard —public-ledgerhq-shared-mediumis a Ledger-hosted runner and can reach JFrog via OIDC (same runner class used inledger-livefor JFrog tasks). The guard was causing a false negative.3. Fixed publish command —
pnpm release -- --no-git-tag --tag sandbox→pnpm exec changeset publish --tag sandbox--no-git-tagis not a valid changeset flag; pnpm was also passing--literally to the script.E2E result: OIDC auth,
.npmrcconfig and changeset all work correctly againstledgerlive-npm-sandbox-green.🔗 Context