fix(ci): remove double run on PR push - #12
Merged
Conversation
branches-ignore: [main] was firing on every feature branch, causing both push and pull_request events to run in parallel on each PR push. Switch to branches: [develop] so push only fires on post-merge develop commits. Fix concurrency group to key on PR number for pull_request events so feature pushes don't cancel each other's PR checks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adjusts the GitHub Actions “[Checks] Pull Request” workflow triggers and concurrency settings to prevent duplicate CI runs on PR pushes, reducing wasted CI capacity in the ts-libs monorepo.
Changes:
- Restricts
pushtriggers todeveloponly, leaving PR validation topull_requestevents. - Updates concurrency grouping to key PR runs by PR number (falling back to
github.reffor non-PR events) so cancellations behave as intended.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gre-ledger
marked this pull request as ready for review
July 17, 2026 12:48
ysitbon
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branches-ignore: [main]was matching every feature branch, so each PR push fired both apushevent and apull_request: synchronizeeventrefs/heads/…vsrefs/pull/N/merge) so neither cancelled the other — every PR push burned two CI slotsFix:
branches-ignore: [main]→branches: [develop]: push only fires post-merge on develop, PRs are handled exclusively by thepull_requesteventgithub.ref→github.event.pull_request.number || github.ref: PR runs key on PR number so a new develop push doesn't cancel an in-flight PR checkNote
Pushes to feature branches with no open PR no longer trigger CI — that's intentional, since they will once a PR is opened.
Test plan
pull_request: synchronize), not twodevelopstill triggers a CI run (viapush: branches: [develop])