1420 sec audit fixes#26
Merged
cedelavergne-ledger merged 22 commits intoJul 8, 2026
Merged
Conversation
warning
may01
reviewed
Jul 2, 2026
may01
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
developRemediates all 10 findings from the Ledger Donjon security audit (BA001038) — memory-corruption bugs (OOB read/write, integer over/underflow) in the operation parser and the blind-sign setting bypass on parse errors — and fixes the design-guideline glyph violations blocking store submission.
Security fixes span operation_parser.c, num_parser.c, formatting.h, and sign.c: bounds/overflow guards on FA2, SDP, decimal and amount formatting; correct rewind on parser fallback; and gating blind-sign on its setting so a malformed transaction can no longer bypass it.
Icon compliance: nano nav arrows resized to 14×14 (with the matching bagl_element fix so they render correctly), and a dedicated 48×48 Apex logo (C_TZ_APP_ICON) since Apex caps glyphs at 48; Stax/Flex keep 64×64.
Tests: blind-sign / parsing-error tests updated to enable blind-signing (they previously relied on the F-09 bug), a new regression test for the disabled-setting reject path, and regenerated Nano/Apex snapshots.