Skip to content

Add ClearSign Support for Staking 2.0 Operations#23

Merged
tdejoigny-ledger merged 28 commits into
LedgerHQ:developfrom
dbaranov-hoodies:1327-clearsign-staking-ops
May 27, 2026
Merged

Add ClearSign Support for Staking 2.0 Operations#23
tdejoigny-ledger merged 28 commits into
LedgerHQ:developfrom
dbaranov-hoodies:1327-clearsign-staking-ops

Conversation

@dbaranov-hoodies

@dbaranov-hoodies dbaranov-hoodies commented Apr 20, 2026

Copy link
Copy Markdown

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

This PR adds clear signing support for Tezos staking 2.0 operations and wrapped token transactions.

Changes
Staking 2.0: Implement clear signing for staking operation types
Wrapped tokens: Enable clear signing support for wrapped token transactions
Unit tests: Expand C-level operation parser unit tests (migrated to CMake-based unit-tests/ structure)
Security audit fixes: Address minor issues flagged in the security audit report
Test utilities: Refactored standalone test utilities (message.py, navigator.py) with improved Tezos encoding helpers

@dbaranov-hoodies
dbaranov-hoodies marked this pull request as draft April 20, 2026 12:29
@codecov-commenter

codecov-commenter commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.93%. Comparing base (8c5dbcf) to head (c3da291).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #23      +/-   ##
===========================================
+ Coverage    81.05%   84.93%   +3.88%     
===========================================
  Files           10       10              
  Lines         1863     2184     +321     
  Branches       449      501      +52     
===========================================
+ Hits          1510     1855     +345     
+ Misses         341      313      -28     
- Partials        12       16       +4     
Flag Coverage Δ
unittests 84.93% <100.00%> (+3.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbaranov-hoodies
dbaranov-hoodies marked this pull request as ready for review April 21, 2026 13:24

@pvoliveira pvoliveira left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one comment.

Comment thread app/src/parser/operation_parser.c

@Fingolfin69 Fingolfin69 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dbaranov-hoodies dbaranov-hoodies changed the title 1327 clearsign staking ops Add ClearSign Support for Staking 2.0 Operations May 27, 2026
@tdejoigny-ledger
tdejoigny-ledger merged commit ba00103 into LedgerHQ:develop May 27, 2026
243 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants