Skip to content

fix(macos): ignore plain clicks without a selection gesture - #9

Merged
Ldsystem merged 1 commit into
mainfrom
codex/fix-ignore-plain-clicks
Aug 27, 2026
Merged

fix(macos): ignore plain clicks without a selection gesture#9
Ldsystem merged 1 commit into
mainfrom
codex/fix-ignore-plain-clicks

Conversation

@Ldsystem

Copy link
Copy Markdown
Owner

Summary

  • ignore stationary single clicks before resolving Accessibility selection state
  • preserve drag-based text selection
  • preserve double- and triple-click word selection using Quartz click counts
  • add regression coverage for gesture classification

Root cause

The macOS global input monitor forwarded every primary-button release to the selection resolver. Supported applications can retain stale Accessibility selection text after a normal click, which made the translation control appear without a new selection.

Verification

  • cargo fmt --manifest-path src-tauri/Cargo.toml --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path src-tauri/Cargo.toml --lib — 153 passed, 7 ignored
  • pnpm check — 81 passed, 5 skipped; typecheck and production build passed
  • Chrome smoke: stationary click stayed silent; drag selection remained selectable
  • Installed macOS app signature, checksum, single-process state, and SQLite quick check verified

@Ldsystem
Ldsystem merged commit ee798eb into main Aug 27, 2026
3 checks passed
@Ldsystem
Ldsystem deleted the codex/fix-ignore-plain-clicks branch August 27, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant