Release v0.1.1 and repair macOS overlay reliability - #1
Merged
Conversation
Release bundles were shipped with no signature at all: only the inner Mach-O carried the linker's ad-hoc signature and Contents/_CodeSignature was absent. macOS still lists such an app under Accessibility and accepts the toggle, but it cannot bind the grant to an unsigned bundle, so the process stays untrusted no matter how often the user grants it. Ad-hoc sign the bundle through Tauri and fail the release build when the artifact comes out unsigned. Document that an ad-hoc identity changes per version, so an update invalidates the previous grant.
reqwest was pulled in with default-features disabled, which silently drops the system-proxy feature. The client then only read HTTP_PROXY-style variables, and a GUI app launched from Finder never inherits those. On any network that reaches Google only through a local proxy, every request went out direct, hung, and surfaced as a translation timeout. Restore system-proxy and socks, and add a manual fixture that contacts the real endpoint with the proxy variables stripped, so only the operating system's own configuration can satisfy it.
Chromium and applications that host a web view build their accessibility tree only once a client asks for it. The first read returns an inert tree with an empty AXSelectedText, so a selection made in Cursor or ChatGPT was never seen while Office, TextEdit and browsers worked. Wake the surface under the pointer when the press begins, which gives it the whole drag to publish its tree, and retry the read once for surfaces that are still waking when the gesture ends.
The display transforms were captured once while the runtime was built, so a display attached afterwards was unknown to the adapter. Accessibility geometry on that display intersected no known bounds, normalisation dropped every fragment, and the selection resolved to nothing, leaving the built-in screen as the only place the button could ever appear. Read the topology from CoreGraphics at each resolution instead. CGDisplayBounds uses the same top-left logical space the accessibility API reports, and the window layer positions overlays at logical * scale, so both agree.
macOS does not apply a new Accessibility toggle to a process that is already running, and this app snapshotted permission only at launch, so the warning stayed up after the user allowed access. Re-read permission while Settings is open, start monitoring if the grant takes effect in place, and tell the user to quit from the menu bar when it does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Release
https://github.com/Ldsystem/desktop-translator/releases/tag/v0.1.1