Add RPM field to data model#8
Merged
Merged
Conversation
data_model.py now returns RPM value
Added 'private_mode=False' to webview.start for compatibility with Pop!_OS 24.04.
Import matplotlib and configure settings for text rendering.
Owner
|
Good catch on the gap — The logic itself works, but it calls raw_rpm = row.get('Rpm', row.get('rpm'))
rpm = float(raw_rpm) if raw_rpm not in (None, '', 'None') else 0.0,Same behavior (falls back to 0.0 on missing/empty/None), fewer dict lookups, and drops the commented-out dead line + duplicate 'FIX:' comments. Happy to take this once it's cleaned up. |
Cleaned comment lines
Cleaner code for rpm verification. Pass the tests
Contributor
Author
|
Using raw_rpm failed the tests. I tried this way, and it works: Dead lines removed. |
Covers the missing-column default (0.0), Rpm/rpm casing, and empty string, plus tidies a leftover comment from an earlier revision that referenced a raw_rpm variable no longer present in the code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data_model.py now returns RPM value
I made that change to use a modified racebox template, adding the RPM field for a custom-made device that outputs data in the same fashion that racebox uses,