fix: resolve 500 error on onboarding due to OAuth ID mismatch and Neon cold start (#428) - #429
Open
aryansondharva wants to merge 2 commits into
Open
Conversation
Contributor
|
@aryansondharva is attempting to deploy a commit to the larythelord's projects Team on Vercel. A member of the Team first needs to authorize it. |
aryansondharva
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses production 500s during onboarding by ensuring authenticated sessions use the correct PostgreSQL UUID for OAuth users and by adding retry protection for Neon scale-to-zero cold starts on the onboarding API route.
Changes:
- Update NextAuth
jwtcallback to resolve OAuth users to the correct DB UUID (and related fields) during sign-in. - Wrap onboarding
GETandPOSTdatabase operations withwithDbRetry()and switch onboarding persistence to anupsert. - Add/adjust onboarding API route tests with a
withDbRetrymock.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/auth.ts | Adjusts JWT token hydration for OAuth sign-ins to prevent non-UUID IDs from reaching downstream DB writes. |
| app/api/user/onboarding/route.ts | Adds withDbRetry around onboarding DB calls and uses upsert to handle missing profiles. |
| tests/api/onboarding.test.ts | Adds onboarding route tests and mocks withDbRetry to keep tests deterministic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+192
to
+201
| } else { | ||
| token.id = user.id; | ||
| } | ||
| } catch (error) { | ||
| console.error('[Auth] jwt database lookup failed:', error); | ||
| token.id = user.id; | ||
| } | ||
| } else { | ||
| token.id = user.id; | ||
| } |
…ookup in jwt callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
Quest Reference