refactor(C9): migrate create-playlist tracks to domain TrackInfo type#322
Merged
Merged
Conversation
Replace Vec<FullTrack> with Vec<TrackInfo> for create_playlist_tracks and create_playlist_search_results in App. The network layer now maps fetched FullTrack results to TrackInfo before storing, keeping rspotify types confined to infra/network. The dispatch site rebuilds Vec<TrackId> from TrackInfo.id strings when submitting the playlist to the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec<FullTrack>withVec<TrackInfo>forcreate_playlist_tracksandcreate_playlist_search_resultsinAppsearch_tracks_for_playlist) now maps fetchedFullTrackresults toTrackInfobefore storing, keeping rspotify types confined toinfra/network/create_playlist.rs) and handler (create_playlist.rs) updated to read domain fields (TrackInfo.name,TrackInfo.artists: Vec<String>)Vec<TrackId>fromTrackInfo.id(base62 strings) when submitting the playlist to the API; residual rspotify at the dispatch site is expected per the slice specTest plan
cargo clippy --no-default-features --features telemetry -- -D warningspasses cleancargo test --no-default-features --features telemetrypasses (261 tests)cargo build(full build with streaming) passescargo fmt --allapplied