[data, lua] Allow Threnody to overwrite other threnodies by tier#10914
Open
PocketDev89 wants to merge 1 commit into
Open
[data, lua] Allow Threnody to overwrite other threnodies by tier#10914PocketDev89 wants to merge 1 commit into
PocketDev89 wants to merge 1 commit into
Conversation
PocketDev89
force-pushed
the
fix-threnody-overwrite
branch
from
July 26, 2026 23:07
6e91d6c to
5eb960a
Compare
All threnodies share one status effect ID, so casting a second element was blocked: the generic same-tier nullifier and the effect's "higher" overwrite both treated a different element at the same tier as a duplicate and gave "no effect." On retail a threnody overwrites any element at an equal or higher tier and is only blocked by a lower tier (e.g. Fire Threnody II blocks Wind Threnody I), regardless of gear. Drop the effect's "higher" override so it uses the default equal-or-higher (matching Dia/Bio), and skip the generic same-tier nullifier for threnody so a different element at the same tier can apply.
PocketDev89
force-pushed
the
fix-threnody-overwrite
branch
from
July 26, 2026 23:20
5eb960a to
a6b77aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Allows Threnody of the same tier to override the other.
screenshot from retail provided by @CriticalXI . ty critical
just a note this is by tier. playing a tier II threnody and switching to a tier 1 threnody even by element will give a no effect. I tested this and have a screenshot:
Steps to test these changes
casted threnody. casted a different threnody of a different element.