Skip to content

[lua,sql,cpp][module] Bard era module additions and settings#10900

Open
CriticalXI wants to merge 1 commit into
LandSandBoat:basefrom
CriticalXI:bard_adjustments
Open

[lua,sql,cpp][module] Bard era module additions and settings#10900
CriticalXI wants to merge 1 commit into
LandSandBoat:basefrom
CriticalXI:bard_adjustments

Conversation

@CriticalXI

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds several new additions to era modules to revert functionality of Bard merits, and Pianissimo to their pre-Abyssea behavior
  • Adjustments to Elegy/Requiem/Threnody to allow them to overwrite the same effect with equal potencies

With Horn > Horn > Piccolo
image

Piccolo all of 1st image > Piccolo First Cast on 2nd Image > No piccolo
image
image

Requiem with the same instrument
image

Steps to test these changes

  • Load modules, and set new setting to false in main.lua
  • See that merited nightingale and troubadour no longer have their new rank effects (instant cast/increased accuracy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant