Skip to content

[lua] Moment of Truth battlefield win event fix#10853

Open
ThrisStraizo wants to merge 1 commit into
LandSandBoat:basefrom
ThrisStraizo:csfixtruth
Open

[lua] Moment of Truth battlefield win event fix#10853
ThrisStraizo wants to merge 1 commit into
LandSandBoat:basefrom
ThrisStraizo:csfixtruth

Conversation

@ThrisStraizo

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes the battlefield win CS trigger so it properly loads or skips if needed.
Players should be able to complete the quest now.

(The fight still needs to be coded to work like retail)

Steps to test these changes

Beat Moment of Truth, don't get stuck anymore.
Complete the quest!

This PR fixes the battlefield win CS trigger so it properly loads or skips if needed.

Co-Authored-By: Nobutadas <nobutadas.one@gmail.com>

@WinterSolstice8 WinterSolstice8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the corresponding quest lua:

            onEventFinish =
            {
                [3] = function(player, csid, option, npc)
                    quest:setVar(player, 'Prog', 4)
                end,

                [32001] = function(player, csid, option, npc)
                    if player:getLocalVar('battlefieldWin') == xi.battlefield.id.MOMENT_OF_TRUTH then
                        quest:setVar(player, 'Prog', 5)
                    end
                end,
            },

seems good, but not sure why 32001 or the battlefield win wasn't happening to begin with. I feel like that would be boiler plate...

@ThrisStraizo

Copy link
Copy Markdown
Contributor Author

Normally it would just work, but the quest itself I think has some weird parameters that could potentially cause and entirely different CS to play depending if you did/or didn't complete a previous objective.

However, despite testing this Tangent told me it wasn't possible to skip any steps, thus, it wasn't actually possible to see the alternate CS, which actually exists. It's like they forgot to code it... or forgot to make a previous step optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants