Unifies message handling and dynamic command aliases - #5
Merged
Conversation
Replaces manual command alias logic with centralized CommandAliasManager from updated library, simplifying command registration and reloading. Updates dependency and documentation to require YskLib 1.6.5. Relates to alias management improvements.
Switches command alias configuration from the legacy 'base' key to a more descriptive 'lmb' key, improving clarity and maintainability. Adds backward compatibility for loading aliases from the previous key if needed, ensuring smooth migrations for existing users.
…ents and unified messaging utilities
…refactored message API
Updates project version references and documentation to 1.5.3. Raises required YskLib version to 1.6.6 to ensure compatibility with upstream changes and improvements.
…ing, and resilience
…lorize to plugin.legacy
…tionController and notification logic
Replaces hardcoded library version with automatic detection to ensure the installed artifact matches the built version and simplifies version management in the workflow.
Raises the minimum required version to ensure compatibility with recent features and bug fixes in the dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lmbkey, deprecating the legacybasekey in configMotivation
Unifying message logic improves maintainability and ensures consistent player/admin messaging throughout the codebase, while incorporating Adventure components for greater style flexibility. The switch to dynamic alias management and a more robust configuration structure prevents aliasing issues and improves user experience for both admins and plugin users.