This repository was archived by the owner on Jul 11, 2026. It is now read-only.
MI PRIMER CODEREVIEW LAURA ALFONSO#25
Open
lauraac wants to merge 2 commits into
Open
Conversation
|
Es importante que subas el resto de tu trabajo para que los próximos code reviews añadan más valor a tu aprendizaje ya que no hay mucho que revisar ;) sigue trabajando! |
HectorBlisS
suggested changes
Feb 11, 2020
HectorBlisS
left a comment
HectorBlisS
left a comment
There was a problem hiding this comment.
Es importante que subas el resto de tu trabajo para que los próximos code reviews añadan más valor a tu aprendizaje ya que no hay mucho que revisar ;) sigue trabajando!
| @@ -0,0 +1,70 @@ | |||
| form { | |||
There was a problem hiding this comment.
Todo esta en orden, pero podrias mejorar tus selectores y evtar tantas clases si usaras más "especificidad" (investiga un poco) para que uses padres y accedas a sus hijos con especificidad:
.container > div h2{
// styles
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hola estoy empezando con javascript