This repository was archived by the owner on Jul 11, 2026. It is now read-only.
TripLife. Squad 2#26
Open
GabyAlvarez wants to merge 56 commits into
Open
Conversation
… merge in master with different changes
…ch other and test fase
Sn fabiola
join branches Fabi
Sn fabiola
Dev contentuser gaby
…d some style issues
Snfabiola
Sn fabiola
HectorBlisS
suggested changes
May 5, 2020
HectorBlisS
left a comment
HectorBlisS
left a comment
Contributor
There was a problem hiding this comment.
Código muy sólido y muy palpable el trabajo en equipo, aún puede modularizarse más separando siempre el DOM de la BD, bien los nombres de variables y funciones pero no tengan miedo a ser más especificas. eviten estilos con slector de id y la repetición de id puede generar errores inesperados.
| }; | ||
| // Initialize Firebase | ||
| firebase.initializeApp(firebaseConfig); | ||
| const database = firebase.database(); |
Contributor
There was a problem hiding this comment.
Si se exporta, esta linea no se repite 😉
| }); | ||
| } | ||
|
|
||
| export const renderPost = (userName, uid) =>{ |
Contributor
There was a problem hiding this comment.
Bien el nombre de la función
Comment on lines
+52
to
+53
| <img id="${doc.id}" src='iconos/edit-tools.png' class='iconoedit' alt="EditPost" /> | ||
| <img id="${doc.id}" src='iconos/interface.png' class='iconodelete' alt="DeletePost" /> |
Contributor
There was a problem hiding this comment.
Sólo debe existir un id único siempre.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.