DigiTareas escolar#24
Conversation
|
added changes in css, profile, edit, and readme |
| "stylelint": "stylelint --aei src/**/*.css", | ||
| "pretest": "npm run htmlhint && npm run eslint && npm run stylelint", | ||
| "test": "jest --coverage", | ||
| "test": "jest", |
There was a problem hiding this comment.
Podrían dejar coverage ó watch
reloadercf
left a comment
reloadercf
left a comment
There was a problem hiding this comment.
En general se ve bien su código, pero considero que 2 personas fueron las que colaboraron más esto en base a sus commits, considero que hay código comentado que podría borrarse, recomiendo revisen en que casos se utiliza let y const esto para tener congruencia con las variables.
| firebase.auth() | ||
| .signInWithPopup(providerFB) | ||
| .then(function(result) { | ||
| console.log(result.user); |
There was a problem hiding this comment.
Recuerden que se deben quitar los console.log al final
There was a problem hiding this comment.
y así con todos los console.log que tienen
| photo:user.photoURL | ||
| } | ||
| db.collection("users").doc(userNew.uid).set(userNew) | ||
| .then(function() { |
There was a problem hiding this comment.
La promesa pudo retornar algo más que un console.log
| //console.log(`${doc.id} => ${doc.data().post}`); | ||
| let postElement = document.createElement('div'); | ||
| let postNew = ` | ||
| <div class="containerPostPrint"> |
There was a problem hiding this comment.
si la clase es para implementar estilos no se debe utilizar camelCase en vez de containerPostPrint, para estilos es mejor container-post-print
| <div class="containerPostPrint"> | |
| <div class="container-post-print"> |
| <img class="imgUser" src="img/user.svg"></img> <p class="nameUser">${doc.data().user}</p> | ||
| </div> | ||
| <div class="btnIcon"> | ||
| <button type="submit" class="editBtn" ${doc.id}, ${doc.data().post} ><img src="img/edit.svg" /></button> | ||
| <button type="submit" class="deleteBtn" data-id="${doc.id}"><img data-id="${doc.id}" src="img/delete.svg" /></button> | ||
| </div> | ||
| <p class="PostPrint">${doc.data().post}</p> | ||
| <textarea class="answer" id="answer"> </textarea> | ||
| <br> | ||
| <div class="sectionLikes"> | ||
| <p class="nroLikes">0<img class="imgLikes" src="img/like.svg" /></p> | ||
| </div> | ||
| <button class="btnAnswer" data-id="${doc.id}">Responder</button> |
There was a problem hiding this comment.
Podrían darle formato a su código, esto facilita la lectura a cualquiera que lo lea ;)
| <img class="imgUser" src="img/user.svg"></img> <p class="nameUser">${doc.data().user}</p> | |
| </div> | |
| <div class="btnIcon"> | |
| <button type="submit" class="editBtn" ${doc.id}, ${doc.data().post} ><img src="img/edit.svg" /></button> | |
| <button type="submit" class="deleteBtn" data-id="${doc.id}"><img data-id="${doc.id}" src="img/delete.svg" /></button> | |
| </div> | |
| <p class="PostPrint">${doc.data().post}</p> | |
| <textarea class="answer" id="answer"> </textarea> | |
| <br> | |
| <div class="sectionLikes"> | |
| <p class="nroLikes">0<img class="imgLikes" src="img/like.svg" /></p> | |
| </div> | |
| <button class="btnAnswer" data-id="${doc.id}">Responder</button> | |
| <img class="imgUser" src="img/user.svg"></img> <p class="nameUser">${doc.data().user}</p> | |
| </div> | |
| <div class="btnIcon"> | |
| <button type="submit" class="editBtn" ${doc.id}, ${doc.data().post} ><img src="img/edit.svg" /></button> | |
| <button type="submit" class="deleteBtn" data-id="${doc.id}"><img data-id="${doc.id}" src="img/delete.svg" /></button> | |
| </div> | |
| <p class="PostPrint">${doc.data().post}</p> | |
| <textarea class="answer" id="answer"> </textarea> | |
| <br> | |
| <div class="sectionLikes"> | |
| <p class="nroLikes">0<img class="imgLikes" src="img/like.svg" /></p> | |
| </div> | |
| <button class="btnAnswer" data-id="${doc.id}">Responder</button> |
|
|
||
| // reply post | ||
|
|
||
| function answer(e){ |
There was a problem hiding this comment.
Su función podria tener un nombre más descriptivo
| const root = document.getElementById('root') | ||
| const viewLogin = ` | ||
| <div class="mainConteinerLogin"> | ||
| <img src="img/portadaDesktop.jpg" alt="" class="imageLoginDesktop"> |
There was a problem hiding this comment.
traten de no dejar vacío los alt porque los buscadores usan esa etiqueta para ubicar las búsquedas, ademas favorece el SEO de una web
| <img src="img/portadaDesktop.jpg" alt="" class="imageLoginDesktop"> | |
| <img src="img/portadaDesktop.jpg" alt="algo" class="imageLoginDesktop"> |
| /* | ||
| const buttonDeletePost = document.querySelector('#btnDeletePost') | ||
| buttonDeletePost.addEventListener('click', deletePost) | ||
|
|
||
| const buttonEditPost = document.querySelector('#btnEditPost') | ||
| buttonEditPost.addEventListener('click', editPost)*/ |
There was a problem hiding this comment.
Si no se utiliza este fragmento de código seria bueno quitarlo, estoy seguro que en 1 año si intentan ver porque comentaron este código posiblemente no se acuerden
| /* | |
| const buttonDeletePost = document.querySelector('#btnDeletePost') | |
| buttonDeletePost.addEventListener('click', deletePost) | |
| const buttonEditPost = document.querySelector('#btnEditPost') | |
| buttonEditPost.addEventListener('click', editPost)*/ |
| const userName = "Laura Flores"; | ||
| const student = "Carolina Flores"; | ||
| const school = "Colegio La Paz"; | ||
| const grade = "1"; | ||
| const group = "A"; | ||
| const teacher = "Melisa Gutierrez"; | ||
| const comment = "Buen día, mi hija se trajo la chamarra de Adriana Juarez, la chamarra tiene su nombre Carolina Flores"; | ||
| const likeCount ="15"; | ||
| const answers =""; | ||
| const viewProfile = ` |
There was a problem hiding this comment.
estas variables que onda?? teóricamente los valores tendrían que asignarse por cada usuario al iniciar sesión
| case "#/": { | ||
| header.appendChild(components.Header()); | ||
| return root.appendChild(components.Home()); | ||
| } |
There was a problem hiding this comment.
Al final de cada caso lleva break; les recomiendo revisar la sentencia de control switch.
| } | |
| break; | |
| } |
| import { example } from '../src/example.js'; | ||
| import { loginGoogle, loginFB, registerUser, addUserPost, showPostUser,sum } from '../src/firebase.js'; | ||
|
|
||
| describe('example', () => { | ||
| describe('login'),() =>{ | ||
|
|
||
| } | ||
|
|
||
| /*describe('Tiene que sumar', () => { | ||
| it('debería ser una función', () => { | ||
| expect(typeof example).toBe('function'); | ||
| expect(sum ()).toBe('function'); | ||
| }); | ||
| }); No newline at end of file | ||
| }); */ No newline at end of file |
There was a problem hiding this comment.
Estoy casi seguro que no funcionaron sus test, sugiero utilizar alguna emulación de sus funciones.
4 participants
Added interface, login functions with fb, gmail and with mail, save users, publish and delete