PR - Mónica#52
Conversation
| if (file) { | ||
|
|
||
| } else { | ||
|
|
There was a problem hiding this comment.
Cuál era tu idea aquí? Cuál era el siguiente paso y el objetivo de esta función?
| }]; | ||
| } | ||
| return | ||
| }; |
There was a problem hiding this comment.
Acá cuál era el objetivo? que iba a devolver si solo era un archivo?
|
|
||
| const isMarkDown = (file) => { | ||
| const fileExt = path.extname(uri); | ||
| console.log(fileExt) |
There was a problem hiding this comment.
Por favor elimina los console innecesarios.
| const linkStatus = (links) => { | ||
|
|
||
| }; | ||
|
|
There was a problem hiding this comment.
Cuál era el objetivo de estas dos funciones?
|
|
||
| const extractLinks = (data) => { | ||
| const getLinks = /((https?:\/\/)|(http?:\/\/)|(www\.))[^\s\n)]+/g; | ||
| const getLinkName = /(?:[^[])([^[]*)(?=(\]+\(((https?:\/\/)|(http?:\/\/)|(www\.))))/g; |
There was a problem hiding this comment.
Por qué tenemos dos regex? para qué son?
| it('return true if file exists', () => { | ||
| expect(mdlink.isFile(testdir)).toBe(false); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Por qué tenemos dos pruebas diferentes? Me parece que hacen lo mismo
| expect(mdlink.getFile(testdir)).toBe('./test/testdir/innertest.md'); | ||
| }); | ||
| }); | ||
|
|
| ) | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Por qué separaste esta función del otro archivo?
| return false; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Me gustan mucho estas dos funciones! me gusta tu approach :)
2 participants
No description provided.