This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Ahora si PR#45
Open
abigail-sanlo wants to merge 11 commits into
Open
Conversation
AdrianaHY
reviewed
Jun 11, 2020
|
|
||
|
|
||
| function getoString() { | ||
|
|
There was a problem hiding this comment.
El nombre de tu función no es tan descriptivo, te recomiendo cambiarlo a algo como readFile
AdrianaHY
reviewed
Jun 11, 2020
| let index = process.argv.indexOf("--file") | ||
| if (index < 0) return console.log("You need to use a valid uri flag --file") | ||
| let uri = process.argv[index + 1] | ||
| let string = fs.readFileSync(uri, 'utf8') |
There was a problem hiding this comment.
lo miso aqui, quizá pondría algo como text ya que es el resultado de toda tu lectura.
AdrianaHY
reviewed
Jun 11, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
There was a problem hiding this comment.
Abi, haz avanzado muchísimo y tu trabajo y tu código están muy bien! procura ser más cuidadosa con los nombres de variables y funciones así como en tus buenas prácticas. Falta testing de cada una de tus funciones, por favor intenta trabajar en ello.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.