This repository was archived by the owner on Jul 11, 2026. It is now read-only.
PR Mdlinks#35
Open
akaren29 wants to merge 5 commits into
Open
Conversation
AdrianaHY
reviewed
Jun 11, 2020
| let fileMd = fs.readFileSync(uri,'utf-8'); | ||
| return fileMd; | ||
| } | ||
|
|
There was a problem hiding this comment.
Cuida la indentación de tus archivos, de esta manera podrá verse más ordenado.
There was a problem hiding this comment.
Podría simplificarse tu función algo como:
function readFile(uri) { return fs.readFileSync(uri,'utf-8'); }
o
const readFile = uri => s.readFileSync(uri,'utf-8');
AdrianaHY
reviewed
Jun 11, 2020
| } | ||
|
|
||
| function searchLinks(fileMd, uri){ | ||
| let linksArr = [] |
There was a problem hiding this comment.
quizá un mejor nombre para la función podría ser getLinks
AdrianaHY
reviewed
Jun 11, 2020
| }) | ||
| }) | ||
| return linksValid; | ||
| }; |
There was a problem hiding this comment.
Por favor cuida mucho la indentación de tus archivos.
AdrianaHY
reviewed
Jun 11, 2020
| } | ||
| }) | ||
| promises.push(promise) | ||
| }) |
AdrianaHY
reviewed
Jun 11, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
There was a problem hiding this comment.
Excelente trabajo Karen! Por favor cuida mucho tu indentación y buenas prácticas, por lo demás todo está muy bien.
También trabaja en tu testing, creo que es la única parte que nos falta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have compassion!!