This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Mariel y Karina#34
Open
marielcarrillo wants to merge 21 commits into
Open
Conversation
cambioscss, imgs, pop up
HectorBlisS
suggested changes
Mar 20, 2020
HectorBlisS
left a comment
HectorBlisS
left a comment
Contributor
There was a problem hiding this comment.
buen trabajo, hay que mejorar las descripciones de los commits. =)
| export const allCharacters = data.results | ||
|
|
||
| //exportar todos los Ricsk´s | ||
| export const allRicks = data.results.filter(value =>(value.name.includes ("Rick"))) |
| @@ -3,8 +3,12 @@ import data from './data/rickandmorty/rickandmorty.js'; | |||
| //funcion para encontrar desde la data a los 5 personajes principales | |||
| export const principalCharacters = data.results.filter(char => | |||
| (char.id==1||char.id==2||char.id==3||char.id==4||char.id==5)) | |||
Contributor
There was a problem hiding this comment.
Esta concatenación es muy buena, solo agregar el tercer =
Comment on lines
+37
to
+41
| let boxCharacters = item.image; | ||
| let nameCharacter = item.name; | ||
| let name = document.createElement('p'); | ||
| let img = document.createElement('img'); | ||
| let btn = document.createElement('button'); |
Contributor
There was a problem hiding this comment.
Podriamos sustituir estos nodos por <p> <img/> <button></button> </p> con "backtics"
Comment on lines
+48
to
+55
| name.style.fontFamily = "kindergarten"; | ||
| name.style.fontSize = "20px"; | ||
| name.style.color = "white"; | ||
| btn.style.border = "none"; | ||
| btn.style.background = "0,0,0,0.0" | ||
| btn.style.width = "20em"; | ||
| btn.style.height = "20em"; | ||
| img.style.width = "14em"; |
Contributor
There was a problem hiding this comment.
Es mucho mejor usar una clase solamente en vex de estilo por estilo
Comment on lines
+2
to
+5
| console.log(principalCharacters) | ||
| console.log(allCharacters) | ||
| /*/funcion recorriendo (swicht) | ||
| const imprimirResultado = document.querySelectorAll('btnPrincipal').addEventListener('click', ); | ||
|
|
||
| switch(imprimirResultado) { | ||
| case btnRick: | ||
| document.querySelector('#rickPrincipal').addEventListener("click", btnRick); | ||
| break; | ||
| }*/ | ||
|
|
||
| //ésta funcion me presneta los datos del personaje 1 que se encuentra en la posición [0] | ||
| document.querySelector('#rickPrincipal').addEventListener("click", btnRick) | ||
|
|
||
| function btnRick (){ | ||
|
|
||
| document.querySelector("#idName").innerHTML = | ||
| `<li>Nombre: ${(principalCharacters[0].name)}</li><br> | ||
| <li>Status: ${(principalCharacters[0].status)}</li><br> | ||
| <li>Especie: ${(principalCharacters[0].species)}</li><br> | ||
| <li>Genero: ${(principalCharacters[0].gender)}</li>` | ||
| }; | ||
|
|
||
| document.querySelector('#mortyPrincipal').addEventListener("click", btnMorty) | ||
|
|
||
| function btnMorty (){ | ||
| document.querySelector("#idName").innerHTML = | ||
| `<li>Nombre: ${(principalCharacters[1].name)}</li><br> | ||
| <li>Status: ${(principalCharacters[1].status)}</li><br> | ||
| <li>Especie: ${(principalCharacters[1].species)}</li><br> | ||
| <li>Genero: ${(principalCharacters[1].gender)}</li>` | ||
| console.log(allRicks) | ||
| console.log(allMortys) |
Contributor
There was a problem hiding this comment.
Usen todos los console.log necesarios para desarrollo pero intenten no ubirlos al repo ;)
Comment on lines
+37
to
+41
| document.querySelector("#idName").innerHTML = | ||
| `<li>Nombre: ${(principalCharacters[2].name)}</li><br> | ||
| <li>Status: ${(principalCharacters[2].status)}</li><br> | ||
| <li>Especie: ${(principalCharacters[2].species)}</li><br> | ||
| <li>Genero: ${(principalCharacters[2].gender)}</li>` |
Comment on lines
+66
to
+71
| function screenCharacters () { | ||
| let screen = document.querySelector(".principalScreen") | ||
| screen.style = "display:none"; | ||
| document.querySelector(".screenCharacters").style.display="block"; | ||
| } | ||
| document.querySelector(".btnAllCharacters").addEventListener("click", screenCharacters) |
Contributor
There was a problem hiding this comment.
Los nombres de funciones un poco más descriptivos
Comment on lines
+24
to
26
| <img src="images/btnAllCharacters.png" alt="" class="btnAllCharacters"> | ||
| <img src="images/btnRicks.png" alt=""> | ||
| <img src="images/btnMortys.png" alt=""> |
Contributor
There was a problem hiding this comment.
Intenten ser más consistentes con las etiquetas si arriba se usaron a, aquí podrian haberlas usado también.
| @@ -6,6 +6,7 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | |||
Contributor
There was a problem hiding this comment.
Avences viernes no es un comentario de commit descriptivo, intenten ser semánticas en todo momento ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.