This repository was archived by the owner on Jul 11, 2026. It is now read-only.
cambios a la carpeta src#30
Open
rinconcitog wants to merge 3 commits into
Open
Conversation
AdrianaHY
reviewed
Mar 29, 2020
| //filtrar por generos | ||
|
|
||
| window.rnmgo = { | ||
| filterData(data, condition) { |
Author
There was a problem hiding this comment.
era una abreviatura para rick and morty go
AdrianaHY
reviewed
Mar 29, 2020
| <P>Si sabes el nombre de tu personaje, escríbelo aquí</p> | ||
| <input id="buscador" type="search"> | ||
| <P>Si no sabes el nombre, buscalo aquí:</br><button id="link_todos"> Ver todos los personajes</button></p> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Recuerda ser consistente con los espacios.
AdrianaHY
reviewed
Mar 29, 2020
| rinckandmorty = answer; | ||
| imageRickandMorty(rinckandmorty); | ||
| } ) | ||
|
|
Contributor
There was a problem hiding this comment.
Recuerda indentar de una mejor manera, así el código podrá leerse con más claridad.
AdrianaHY
reviewed
Mar 29, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
Contributor
There was a problem hiding this comment.
Muy buen trabajo! Recuerda volver siempre a las buenas prácticas. Felicidades por el uso de fetch.
Author
|
Hola Adri, gracias, rngo el nombre que le puse para simplificar Rick and
morty go por que a veces es complicado, digo para mi, ponerle el nombre a
las funciones para que ya no se me confundan unas con otras 😐
El El dom, 29 de marzo de 2020 a la(s) 2:05 p.m., AdrianaHY <
notifications@github.com> escribió:
… ***@***.**** commented on this pull request.
Muy buen trabajo! Recuerda volver siempre a las buenas prácticas.
Felicidades por el uso de fetch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOPERIWIREMDSDQQMPV4PI3RJ6SY3ANCNFSM4LJMULEQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.