This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Code review Kari & Yeral "Easy patient data"#29
Open
YeraldinCasas wants to merge 98 commits into
Open
Conversation
Author
|
It was possible that the card stayed where we want |
AdrianaHY
reviewed
Mar 22, 2020
| // import data from './data/steam/steam.js'; | ||
| // import data from './data/steam/worldbank.js'; | ||
|
|
||
| // esta es una función de ejemplo |
Contributor
There was a problem hiding this comment.
Hay que eliminar el código que no está siendo utilizado.
AdrianaHY
reviewed
Mar 22, 2020
| data.entry.forEach(recorrer) | ||
|
|
||
| data.entry.map(recorrer) | ||
| //2.- función que recibe c/item y aacedemos a los datos que queremos y los almacenamos en un objeto nuevo, y a ese objeto nuevo lo metemos dentro de un array |
Contributor
There was a problem hiding this comment.
Hay que ser más consistentes con el espaciado en nuestro código.
AdrianaHY
reviewed
Mar 22, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
Contributor
There was a problem hiding this comment.
Su código es muy ordenado, en general muy buen trabajo. Dado que conozco muy bien lo que hicieron, solo trabajen las pequeñas cosas que les comenté. Felicidades!
YeraldinCasas
changed the title
YeraldinCasas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is what we have until now, we are a bit stuck in the filtering and in the cards. I Yeraldin do not know what I did with the branches and I could not upload the changes with Git, but I will keep looking for the why and for the moment I uploaded the files directly. Thank you!