Fabiola#25
Conversation
second try to merge with master
Merging changes
first page almost complete
modal styling
graphic in every indicator
HectorBlisS
left a comment
HectorBlisS
left a comment
There was a problem hiding this comment.
Muy bien el repo, de los mejores, eviten el español a toda costa, eviten camelCase en CSS y sean más descriptivas con los commits, también en ingles. Felicidades por el gran trabajo, se nota el trabajo progresivo y en equipo.
| <script type="module" src="indicators.js"></script> | ||
| </body> | ||
| </html> | ||
|
|
There was a problem hiding this comment.
Bien por borrar comentarios y código sobrante
| }); | ||
| } | ||
|
|
||
| const removeGraphic = () => { |
There was a problem hiding this comment.
Bien los nombres en ingles y el camelCase
| } | ||
|
|
||
| const showGraphic = (indicator) => { | ||
| let toggleButtonFlag = false; |
There was a problem hiding this comment.
Esta variable nunca se usó
| } | ||
|
|
||
| // When the user clicks (x) of the modal, close it | ||
| span.onclick = function() { |
There was a problem hiding this comment.
De preferencia usar addEventListener
| width: 60%; | ||
|
|
||
| box-shadow: 0 4px 8px 0 rgba(0,0,0,0.2),0 6px 20px 0 rgba(0,0,0,0.19); | ||
| box-shadow: 0 8px 16px 0 rgba(0,0,0,0.4),0 10px 22px 0 rgba(0,0,0,0.25); |
|
|
||
| describe('example', () => { | ||
| describe('bankData', () => { | ||
|
|
||
| it('debería ser una función', () => { | ||
| expect(typeof example).toBe('function'); | ||
| expect(typeof bankData).toBe('function'); | ||
| }); | ||
|
|
||
| describe('example', () => { | ||
| //describe('example', () => { |
There was a problem hiding this comment.
Muy bien por agregr tests
| @@ -56,18 +49,14 @@ for (let i=0; i< indicatorName.length; i ++){ | |||
| aTwitter.setAttribute("href","https://twitter.com/share?url=<URL>&text=<TEXT>via=<USERNAME>"); | |||
| aFacebook.setAttribute("href","https://www.facebook.com/sharer/sharer.php?u=<URL>"); | |||
| aMail.setAttribute("href","mailto:?subject=<SUBJECT>&body=<BODY>"); | |||
There was a problem hiding this comment.
podrian intentar usar más `` para dibujar el html y mejorar la lectura
| let graphicModal = document.getElementById("graphicModal"); | ||
|
|
||
| let graphic = document.createElement("canvas"); | ||
| graphic.setAttribute("id","myChart"); |
| data:{ | ||
| labels:Object.keys(indicatorData), | ||
| datasets:[{ | ||
| label:'PER', |
There was a problem hiding this comment.
Bien el uso de graficas
| } | ||
|
|
||
| // When the user clicks anywhere outside of the modal, close it | ||
| window.onclick = function(event) { |
There was a problem hiding this comment.
Esto no es necesario si el script está al final de la etiueta body
3 participants
Project name: Bars & Dots
Developers: Eliza Olmedo y Fabiola González