This repository was archived by the owner on Jul 11, 2026. It is now read-only.
Revisar#22
Open
Oralia wants to merge 30 commits into
Open
Conversation
…demas indicadores
HectorBlisS
suggested changes
Mar 25, 2020
HectorBlisS
left a comment
HectorBlisS
left a comment
Contributor
There was a problem hiding this comment.
Sean más descriptivas en los comentarios de los commits, bien por el proyecto final, muy interesante y los filtros complejos, puedo ver muy poco trabajo de Abi, no sé si trabajaron juntas y después subió Ori, pero se percibe más trabajo de un de ustedes. Recuerden poner todo en ingles de ahora en adelante.
|
|
||
| newdataViolencia = countryData.indicators.filter(indicators=> | ||
| { | ||
| return (indicators.indicatorName.includes("mujeres")|indicators.indicatorName.includes("Mujeres")) && (indicators.indicatorName.includes("violencia") |
Contributor
There was a problem hiding this comment.
Muy bien el trabajo con la discriinación de data
| }) | ||
|
|
||
| // función que retorna los nombres de los indicadores para Brasil "Mujeres y violencia" | ||
| for (var i = 0; i < newdataViolencia.length; i++) |
Contributor
There was a problem hiding this comment.
Preferible usar forEach o map
| } | ||
|
|
||
| //Filtro que proporciona los indicadores de "Mujeres y Negocios" | ||
| function negocios(countryData){ |
Contributor
There was a problem hiding this comment.
Nombres de funciones en ingles
| //Filtro que proporciona los indicadores de "Mujeres y Empleo" | ||
| function empleo (countryData){ | ||
| let newdataEmpleo=[]; | ||
| let indicatorEmpleo=[]; |
Contributor
There was a problem hiding this comment.
Los nombres de variables, fnuciones, id, clases ya no serán tolerables en español en el próximo proyecto.
| } | ||
| for (let i = 0; i < newdataBrasil.length; i++) { | ||
| let indicatorList = document.getElementById("indicatorsSelectBrasil"); | ||
| let indicator= document.createElement("option"); |
Contributor
There was a problem hiding this comment.
Muy bien por crear las opciones dinámicas
Comment on lines
+43
to
+68
|
|
||
| //) | ||
| //console.log(newdataMexico); | ||
| //) | ||
| //console.log(newdataMexico); | ||
|
|
||
| //Filtro que prporciona los ndicadores que contienen la palabra mujer en Brasil | ||
| //Filtro que prporciona los ndicadores que contienen la palabra mujer en Brasil | ||
|
|
||
| //let newdataBrasil = data.BRA.indicators.filter(indicator=> | ||
| // { | ||
| //let newdataBrasil = data.BRA.indicators.filter(indicator=> | ||
| // { | ||
| // return indicator.indicatorName.includes("mujeres") | ||
| //} | ||
|
|
||
| //) | ||
| //console.log(newdataBrasil); | ||
| //) | ||
| //console.log(newdataBrasil); | ||
|
|
||
| //Filtro que prporciona los ndicadores que contienen la palabra mujer en Chile | ||
| //Filtro que prporciona los ndicadores que contienen la palabra mujer en Chile | ||
|
|
||
| //let newdataChile = data.CHL.indicators.filter(indicator=> | ||
| //let newdataChile = data.CHL.indicators.filter(indicator=> | ||
| //{ | ||
| //return indicator.indicatorName.includes("mujeres") | ||
| //return indicator.indicatorName.includes("mujeres") | ||
| //} | ||
|
|
||
| //) | ||
| //console.log(newdataChile); | ||
| //) | ||
| //console.log(newdataChile); | ||
|
|
||
| //Para visualizar que hay en data | ||
| //console.log(datos(data)); | ||
| //Para visualizar que hay en data | ||
| //console.log(datos(data)); |
Contributor
There was a problem hiding this comment.
Todo el código comentado mejor eliminarlo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.