PR by LizethRivera04 · Pull Request #7 · Laboratoria/CDMX009-BurgerQueen

LizethRivera04 · 2020-07-22T14:06:37Z

Pull request from Ely Flores and Liz Rivera

Test branch

Dev liz

reloadercf

Ely & Liz, Me gusto mucho que su proyecto cumple con todas las funcionalidades técnicas, tengo 3 recomendaciones: la primera es la consistencia de la información, recuerden que el código tiene que ser fácil de interpretar para cualquier persona y la segunda recomendación es modularizar aun más su código, la recomendación en esto es separar las responsabilidades e implementar el uso de helpers, la tercer recomendación es incorporar más el uso de GitHub, veo solo 6 commits y eso no permite visualizar del todo el trabajo de las 2, la recomendación es que exploten al máximo las funcionalidades de GitHub, quiero destacar que hicieron TEST, eso esta cool.

reloadercf · 2020-07-23T14:12:32Z

@@ -0,0 +1,36 @@
+favicon.ico,499162500000,d96ddbc4933b04e12c738ab39f469573143949ca2c39eda0a49d16f83d40c319


agregar al git ignore

reloadercf · 2020-07-23T14:13:28Z

+yarn-debug.log*
+yarn-error.log*
+
+


tus imágenes pueden ir en una carpeta llamada assets/img

reloadercf · 2020-07-23T14:15:39Z

+import React, { Fragment, useState, useEffect } from 'react';
+import coffeMilk from './imgs/coffeMilk.png';
+import coffe from './imgs/coffe.png';
+import sandwich from './imgs/sandwich.png';
+import juice from './imgs/juice.png';
+import simpleBurguer from './imgs/simpleBurguer.png';
+import doubleBurguer from './imgs/doubleBurguer.png';
+import frenchFries from './imgs/frenchFries.png';
+import onion from './imgs/onion.png';
+import smallWater from './imgs/smallWater.png';
+import bigWater from './imgs/bigWater.png';
+import smallSoda from './imgs/smallSoda.png';
+import bigSoda from './imgs/bigSoda.png';
+
+
+import { db } from './firebase/firebase-config'
+import Routes from './components/Routes.js';


Suggested change

import React, { Fragment, useState, useEffect } from 'react';

import coffeMilk from './imgs/coffeMilk.png';

import coffe from './imgs/coffe.png';

import sandwich from './imgs/sandwich.png';

import juice from './imgs/juice.png';

import simpleBurguer from './imgs/simpleBurguer.png';

import doubleBurguer from './imgs/doubleBurguer.png';

import frenchFries from './imgs/frenchFries.png';

import onion from './imgs/onion.png';

import smallWater from './imgs/smallWater.png';

import bigWater from './imgs/bigWater.png';

import smallSoda from './imgs/smallSoda.png';

import bigSoda from './imgs/bigSoda.png';

import { db } from './firebase/firebase-config'

import Routes from './components/Routes.js';

import React, { Fragment, useState, useEffect } from 'react';

import { db } from './firebase/firebase-config'

import Routes from './components/Routes.js';

import coffeMilk from './imgs/coffeMilk.png';

import coffe from './imgs/coffe.png';

import sandwich from './imgs/sandwich.png';

import juice from './imgs/juice.png';

import simpleBurguer from './imgs/simpleBurguer.png';

import doubleBurguer from './imgs/doubleBurguer.png';

import frenchFries from './imgs/frenchFries.png';

import onion from './imgs/onion.png';

import smallWater from './imgs/smallWater.png';

import bigWater from './imgs/bigWater.png';

import smallSoda from './imgs/smallSoda.png';

import bigSoda from './imgs/bigSoda.png';

Primero las dependencias

reloadercf · 2020-07-23T14:17:36Z

+
+function App() {
+  const [breakfasts, saveBreakfast] = useState([
+    { id: 1, dish: "Café con leche", img: coffeMilk, price: 7, quantity: 1 },
+    { id: 2, dish: "Café americano", img: coffe, price: 5, quantity: 1 },
+    { id: 3, dish: "Sandwich de jamón y queso", img: sandwich, price: 10, quantity: 1 },
+    { id: 4, dish: "Jugo de frutas natural", img: juice, price: 7, quantity: 1 }
+  ])
+  const [lunchs, saveLunch] = useState([
+    { id: 5, idItem: 0, dish: "Hamburguesa simple", img: simpleBurguer, price: 10, addittions: [], quantity: 1 },
+    { id: 6, idItem: 0, dish: "Hamburguesa doble", img: doubleBurguer, price: 15, addittions: [], quantity: 1 },
+    { id: 7, dish: "Papas fritas", img: frenchFries, price: 5, quantity: 1 },
+    { id: 8, dish: "Aros de cebolla", img: onion, price: 5, quantity: 1 },
+    { id: 9, dish: "Agua 500ml", img: smallWater, price: 5, quantity: 1 },
+    { id: 10, dish: "Agua 750ml", img: bigWater, price: 7, quantity: 1 },
+    { id: 11, dish: "Soda 500ml", img: smallSoda, price: 7, quantity: 1 },
+    { id: 12, dish: "Soda 750ml", img: bigSoda, price: 7, quantity: 1 },
+  ])
+


Suggested change

function App() {

const [breakfasts, saveBreakfast] = useState([

{ id: 1, dish: "Café con leche", img: coffeMilk, price: 7, quantity: 1 },

{ id: 2, dish: "Café americano", img: coffe, price: 5, quantity: 1 },

{ id: 3, dish: "Sandwich de jamón y queso", img: sandwich, price: 10, quantity: 1 },

{ id: 4, dish: "Jugo de frutas natural", img: juice, price: 7, quantity: 1 }

])

const [lunchs, saveLunch] = useState([

{ id: 5, idItem: 0, dish: "Hamburguesa simple", img: simpleBurguer, price: 10, addittions: [], quantity: 1 },

{ id: 6, idItem: 0, dish: "Hamburguesa doble", img: doubleBurguer, price: 15, addittions: [], quantity: 1 },

{ id: 7, dish: "Papas fritas", img: frenchFries, price: 5, quantity: 1 },

{ id: 8, dish: "Aros de cebolla", img: onion, price: 5, quantity: 1 },

{ id: 9, dish: "Agua 500ml", img: smallWater, price: 5, quantity: 1 },

{ id: 10, dish: "Agua 750ml", img: bigWater, price: 7, quantity: 1 },

{ id: 11, dish: "Soda 500ml", img: smallSoda, price: 7, quantity: 1 },

{ id: 12, dish: "Soda 750ml", img: bigSoda, price: 7, quantity: 1 },

])

import Data from './utils/Data.js'

function App() {

reloadercf · 2020-07-23T14:18:41Z

+    items: [],
+    totalProducts: 0,
+    total: 0,
+    state: "pending"


Suggested change

state: "pending"

state: "pending" //all status

reloadercf · 2020-07-23T15:06:50Z

+
+
+                {/* Show error if the form is empty when click send the kitchen */}
+                {error ? <p className="error-form">Todos los campos son obligatorios</p> : null}


Suggested change

{error ? <p className="error-form">Todos los campos son obligatorios</p> : null}

{error && <p className="error-form">Todos los campos son obligatorios</p> : null}

reloadercf · 2020-07-23T15:08:30Z

+    color: $white;
+    a{
+        text-decoration: none;
+
+        p{
+            margin-top: 0;
+            color: $white;
+          }
+    }
+


Suggested change

color: $white;

a{

text-decoration: none;

p{

margin-top: 0;

color: $white;

}

}

color: $white;

a{

text-decoration: none;

p{

margin-top: 0;

color: $white;

}

}

reloadercf · 2020-07-23T15:09:03Z

+    select{
+       @include select;
+       width: 60%;
+        align-self: center;
+
+    }
+    i{
+        align-self: end;
+        color: #EB60DD;
+        font-size: 50px;
+    }
+}


Suggested change

select{

@include select;

width: 60%;

align-self: center;

}

i{

align-self: end;

color: #EB60DD;

font-size: 50px;

}

}

select{

@include select;

width: 60%;

align-self: center;

}

i{

align-self: end;

color: #EB60DD;

font-size: 50px;

}

}

reloadercf · 2020-07-23T15:10:43Z

+const Add = ({ idItem, dish, order, breakfasts, lunchs, setOrder }) => {
+
+
+    const addQuantity = (id) => {


Suggested change

const addQuantity = (id) => {

const handleaddQuantity = (id) => {

reloadercf · 2020-07-23T15:13:03Z

@@ -0,0 +1,163 @@
+import React from 'react';
+import ReactDOM from 'react-dom';
+


puede mejorarse la modularización

Depuration code

LizethRivera04 added 6 commits June 9, 2020 13:30

Getting starting

11c6381

Test branch

3d546b7

Merge pull request #1 from LizethRivera04/Lizeth

85a3abe

Test branch

Project deployed and functionality woks

846d5a6

README modification, test files ordered

1d89038

Merge pull request #2 from LizethRivera04/devLiz

982c7a0

Dev liz

reloadercf suggested changes Jul 23, 2020

View reviewed changes

LizethRivera04 added 2 commits July 23, 2020 11:19

Depuration code

ab587db

Merge pull request #3 from LizethRivera04/devLiz

507c953

Depuration code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PR#7

PR#7
LizethRivera04 wants to merge 8 commits into
Laboratoria:masterfrom
LizethRivera04:master

LizethRivera04 commented Jul 22, 2020

Uh oh!

reloadercf left a comment

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

reloadercf Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,36 @@
		favicon.ico,499162500000,d96ddbc4933b04e12c738ab39f469573143949ca2c39eda0a49d16f83d40c319



		{/* Show error if the form is empty when click send the kitchen */}
		{error ? <p className="error-form">Todos los campos son obligatorios</p> : null}

	{error ? <p className="error-form">Todos los campos son obligatorios</p> : null}
	{error && <p className="error-form">Todos los campos son obligatorios</p> : null}

		const Add = ({ idItem, dish, order, breakfasts, lunchs, setOrder }) => {


		const addQuantity = (id) => {

	const addQuantity = (id) => {
	const handleaddQuantity = (id) => {

		@@ -0,0 +1,163 @@
		import React from 'react';
		import ReactDOM from 'react-dom';

		yarn-debug.log*
		yarn-error.log*

Uh oh!

Conversation

LizethRivera04 commented Jul 22, 2020

Uh oh!

reloadercf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants