RockyBurger by Edith Ortiz by EdithOrt · Pull Request #15 · Laboratoria/CDMX009-BurgerQueen

EdithOrt · 2020-08-11T03:17:17Z

No description provided.

New branch and new changes

Dev iris

errors

Functional App

Changes on readme

Gh pages1.1

Preview

reloadercf

Edith me gusto mucho el código para el desarrollo de tu proyecto, tengo una recomendación:
La consistencia en tu proyecto es importante, como por ejemplo definir bien el nombre de funciones y variables, la consistencia te permitirá navegar mejor en tu código, por lo demás esta muy genial.

reloadercf · 2020-08-13T16:44:26Z

@@ -0,0 +1,2 @@
+node_modules/


esto esta bien, recordando también que puedes tener un gitignore al crear tu proyecto con react

seria bueno que agregues tu carpeta build al gitignore

reloadercf · 2020-08-13T16:45:57Z

+      work correctly both with client-side routing and a non-root public URL.
+      Learn how to configure a non-root public URL by running `npm run build`.
+    -->
+    <title>React App</title>


cambio por algo personalizado

reloadercf · 2020-08-13T16:46:54Z

@@ -0,0 +1,22 @@
+import React from 'react';
+// import { BrowserRouter, Route, Switch } from 'react-router-dom';


si no se usa borralo

reloadercf · 2020-08-13T16:47:21Z

+import { Switch, Route, HashRouter } from "react-router-dom";
+import Order from './Root/Order';
+import Kitchen from './Root/Kitchen';
+import Finish from './Root/Finish'
+import Navigation from './components/Nav/Navigation'


Suggested change

import { Switch, Route, HashRouter } from "react-router-dom";

import Order from './Root/Order';

import Kitchen from './Root/Kitchen';

import Finish from './Root/Finish'

import Navigation from './components/Nav/Navigation'

import { Switch, Route, HashRouter } from "react-router-dom";

import Order from './Root/Order';

import Kitchen from './Root/Kitchen';

import Finish from './Root/Finish'

import Navigation from './components/Nav/Navigation'

reloadercf · 2020-08-13T16:48:06Z

+import React, { useState, useEffect } from 'react';
+import { db } from '../firebase-config';
+import ResumeOrder from '../components/resumeOrder/ResumeOrder'
+import './finish.css'


Suggested change

import React, { useState, useEffect } from 'react';

import { db } from '../firebase-config';

import ResumeOrder from '../components/resumeOrder/ResumeOrder'

import './finish.css'

import React, { useState, useEffect } from 'react';

import './finish.css'

import { db } from '../firebase-config';

import ResumeOrder from '../components/resumeOrder/ResumeOrder'

reloadercf · 2020-08-13T16:55:09Z

+import React, { useState } from 'react';
+import Menu from '../components/Menu/Menu'
+import products from '../data/products';
+import PreviewOrder from '../components/PreviewOrder/PreviewOrder'
+import './order.css'
+import { Modal, Button, Checkbox } from 'antd';


Suggested change

import React, { useState } from 'react';

import Menu from '../components/Menu/Menu'

import products from '../data/products';

import PreviewOrder from '../components/PreviewOrder/PreviewOrder'

import './order.css'

import { Modal, Button, Checkbox } from 'antd';

import React, { useState } from 'react';

import { Modal, Button, Checkbox } from 'antd';

import './order.css'

import Menu from '../components/Menu/Menu'

import products from '../data/products';

import PreviewOrder from '../components/PreviewOrder/PreviewOrder'

reloadercf · 2020-08-13T16:56:55Z

+import PreviewOrder from '../components/PreviewOrder/PreviewOrder'
+import './order.css'
+import { Modal, Button, Checkbox } from 'antd';
+


podrías implementar helpers para react

reloadercf · 2020-08-13T16:57:47Z

+import logo from '../../assets/logo-rocky.png'
+import './StyleNavigation.css'
+
+const Navigation = (props) =>{


es mejor destructurar

Suggested change

const Navigation = (props) =>{

const Navigation = () =>{

{ history }

Suggested change

const Navigation = (props) =>{

const Navigation = ({ history } ) =>{

reloadercf · 2020-08-13T16:59:45Z

+    justify-content: center
+    color: white
+
+.Table


Suggested change

.Table

.table

reloadercf · 2020-08-13T17:00:09Z

+                    </div>
+                </div>
+                }
+            {/* PASAR FUNCIÓN QUE CAMBIE EL ESTADO EN FIREBASE */}


borralo

Suggested change

{/* PASAR FUNCIÓN QUE CAMBIE EL ESTADO EN FIREBASE */}

IrisFyD and others added 30 commits June 11, 2020 13:18

create initial structure with react

d3d59b1

accommodate files

649c7f9

git ignore node modules

f06a609

delete .DS_Store

fc6eddf

initializing html skeleton

87ed930

Merge pull request IrisFyD#19 from IrisFyD/edith

a22a908

New branch and new changes

pull edith

b614590

ramas fusionadas

b400ab0

firts compononts

fc8ab6b

Merge pull request IrisFyD#20 from IrisFyD/devIris

f71afd6

Dev iris

merge of files

a5b9ae9

brackfast

0953900

new changes

65ad6d0

add img, routeer

5bff8be

select my button

480b08f

Addig buttons on images

1bfe308

starting functionality to add products to order

a6e6db0

Initialized delete products of order

faf7230

Error with counter total order

3300ca9

firebase, get allOrders from firebase, show allOrders in virtualDOM

90674be

firebase and get allOrders from firebase, show orders in virtualDOM

32ed32c

errors

d421ab6

Merge pull request IrisFyD#21 from IrisFyD/EdithOrt

a809bb9

errors

In the order you can already add quantities of products

017ce90

the user can delete products of the order

b992ac8

The user can delete with button 'substract'

0a0b1dd

The user can view orders in window kitchen

f2a2a01

firts version

54be32a

window kitchen 80% finished

b31fcca

Window finish with functionallity

f129a89

EdithOrt and others added 11 commits August 6, 2020 11:35

Advances of styles

840e35b

Styles of kitchen

44faa56

Merge pull request #1 from EdithOrt/preview

fe3fc11

Functional App

I still can't do tests with Jest

cef8149

Merge pull request #2 from EdithOrt/preview

f1a9d7e

Changes on readme

last changes

ef4da7e

add functionallity for gh-pages

fb7d222

add build and deploy

e03c13a

merge package

0f23d94

Merge pull request #3 from EdithOrt/gh-pages1.1

98c2630

Gh pages1.1

Merge pull request #4 from EdithOrt/preview

aab01de

Preview

reloadercf suggested changes Aug 13, 2020

View reviewed changes

		@@ -0,0 +1,22 @@
		import React from 'react';
		// import { BrowserRouter, Route, Switch } from 'react-router-dom';

	const Navigation = (props) =>{
	const Navigation = ({ history } ) =>{

Uh oh!

Conversation

EdithOrt commented Aug 11, 2020

Uh oh!

reloadercf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants